search

marcelreppi / moodle-buddy

Moodle Buddy is a browser plugin that offers mass download and notification functionality to the Moodle learning management platform
https://moodle-buddy.vercel.app
GNU Affero General Public License v3.0
39 stars 3 forks source link

Disabling "Download Moodle folders as ZIP files whenever possible" can cause files to be missed #14

Closed asdsadsaasd12312132 closed 3 years ago

asdsadsaasd12312132 commented 3 years ago

I disabled this option and I noticed some folders were not downloaded at all. I retried with the option enabled and all folders were downloaded.

marcelreppi commented 3 years ago

Is it possible to share a screenshot of the Moodle folder structure where this occurred?

asdsadsaasd12312132 commented 3 years ago

2/5 folders were not downloaded. I remember Soil Mechanics Lecture Notes did not download. I forgot what the other one was.

image

image

marcelreppi commented 3 years ago

Thanks for sharing. Unfortunately, I am not really sure why this behavior might occur, and I can't really debug it without having access to your Moodle website and the source code of it.

However, I will keep this issue open for anyone who might also be running into the same issue. Thanks a lot for reporting! :)

asdsadsaasd12312132 commented 3 years ago

Actually, I think the cause was actually the course having 2 folders with the same name rather than the zip option being unticked because I retested with the zip option ticked and it still missed some folders. I think this problem also occurs with files since I find that this extension regularly misses files. It is only necessary for the course to have 2 items with the same name for items to be missed in the download. Any item can be missed at random; not just the items with the same name.

marcelreppi commented 3 years ago

Thank you for further investigating!

This is really weird because during my testing there is no issue with files and folders having the same name. The browser automatically makes the filename unique. Works both in Firefox and Chrome. Which type of files are being missed? I might have unknowingly not added support for certain Moodle file types. If there is an error during download might fail. Can you download the missed files manually?

asdsadsaasd12312132 commented 3 years ago

Thank you for further investigating!

This is really weird because during my testing there is no issue with files and folders having the same name. The browser automatically makes the filename unique. Works both in Firefox and Chrome. Which type of files are being missed? I might have unknowingly not added support for certain Moodle file types. If there is an error during download might fail. Can you download the missed files manually?

Yes. Here is a video of the course https://youtu.be/jN7j8btJUSc. Here are all the files for the course https://www.mediafire.com/file/4olbksocnltb4rn/MINE3310_Mine_Geomechanics_%2528T1_2020%2529.7z/file