search

marcelstoer / docker-nodemcu-build

Docker image to build NodeMCU firmware for the ESP8266 on your machine
https://hub.docker.com/r/marcelstoer/nodemcu-build/
MIT License
131 stars 63 forks source link

Is this project still maintained? #102

Closed signed-log closed 10 months ago

signed-log commented 1 year ago

Seeing that there hasn't been an update to DNB since 2021, I'd like to ask if this project is still maintained. If it's not anymore, I'd love to take it over/help maintain it

marcelstoer commented 1 year ago

Thanks for reaching out. The project is still maintained as in "I'll fix bugs and accept PRs". However, the last version either just works or...nobody is using it anymore 😄 Hence, no new commits in quite a while.

The only thing that really bugs me about the current version is #101. So, I'd be gladly accepting your offer to help maintain this project.

signed-log commented 1 year ago

Would you be OK with having two distinct images for esp32 and esp8266. I am asking because of the espressif/idf docker image which has everything ready to use

marcelstoer commented 1 year ago

Oh, interesting, didn't know they've been publishing IDF Docker images for years. Offering a single image certainly has its advantages for the user (maybe not for the maintainers).

signed-log commented 1 year ago

I see potential version conflicts it we were to use the IDF Docker image here.

I would just find a way to bypass the submodule and use the built-in toolchain (this would mean just bypassing the Makefile and calling idf.py directly)

I wanted this image to use the same Ubuntu version as we use for the NodeMCU CI build on GitHub. That's currently not the case anymore; not good

Understood, already made it use 20.04 in my local fork rn, will be able to test later

marcelstoer commented 1 year ago

this would mean just bypassing the Makefile and calling idf.py directly

From what I understand this is quite likely to fail or be instable. NodeMCU is strictly tied to the one specific IDF version it references through the Git submodule.

signed-log commented 1 year ago

v4.4.3 is a tag for the Docker image

marcelstoer commented 1 year ago

We need to determine the correct IDF version based on the NodeMCU version the user checked out. It would be a major PITA if

signed-log commented 1 year ago

Seeing the issue now, this is a non-starter yeah

marcelstoer commented 10 months ago

Any further discussions should continue at #101.