search

marcelstoer / docker-nodemcu-build

Docker image to build NodeMCU firmware for the ESP8266 on your machine
https://hub.docker.com/r/marcelstoer/nodemcu-build/
MIT License
129 stars 63 forks source link

branch names with slashes result in build errors #14

Closed simukka closed 8 years ago

simukka commented 8 years ago

Steps to reproduce:

  1. Create a branch name along the lines of build/foo in nodemcu-firmware
  2. Following the docker build instructions, start a build.
  3. The build process will error out with srec_cat: nodemcu_float_build/foo_20160601-2046.bin: 1: open: No such file or directory [2]: No such file or directory

Exploratory fix: git rev-parse --abbrev-ref HEAD | sed -r 's/[\/\\]+/_/g'

This will replace every occurrence of /, and \ with _.

marcelstoer commented 8 years ago

Yep, that's to be expected. Your fix is fine. Can you please create a PR from your commit?

marcelstoer commented 8 years ago

Thanks.