search

marcelstoer / docker-nodemcu-build

Docker image to build NodeMCU firmware for the ESP8266 on your machine
https://hub.docker.com/r/marcelstoer/nodemcu-build/
MIT License
128 stars 63 forks source link

Support custom targets for build command #84

Closed mk-pmb closed 4 years ago

mk-pmb commented 4 years ago

Also thanks for this project! :moneybag:

HHHartmann commented 4 years ago

Maybe we could just pass everything else on the command line afterbuild just like in lfs-image

HHHartmann commented 4 years ago

It might also make sense to also omit clean if custom targets are given.

mk-pmb commented 4 years ago

Maybe we could just pass everything else on the command line afterbuild just like in lfs-image

I prefer the env var because it gives those values a name. Makes it easier to understand their role.

It might also make sense to also omit clean if custom targets are given.

You're right, thanks! Fixed.

HHHartmann commented 4 years ago

I prefer the env var because it gives those values a name. Makes it easier to understand their role.

True. But just adding the targets after make/build is how it is done on cli and would feel the natural and obvious way to do it.

mk-pmb commented 4 years ago

Actually, why not have both? Once this is merged, you could just make another PR that puts a line like

if [ -n "$*" ]; then BUILD_MAKE_TARGETS=; fi

above the make commands, and add "$@" to the end of the make command.

Edit: Nope, that would add to the defaults. I'll rewrite my PR so it sets those defaults earlier, so you can overwrite them easier.

HHHartmann commented 4 years ago

Yeah we can have both. Great. Heading for bed again now.

HHHartmann commented 4 years ago

So this one is ready to go?

marcelstoer commented 4 years ago

Sorry, somehow must have lost track of this.