marcelstoer / docker-nodemcu-build

Docker image to build NodeMCU firmware for the ESP8266 on your machine
https://hub.docker.com/r/marcelstoer/nodemcu-build/
MIT License
131 stars 63 forks source link

Feature Request: Official vanilla build in GitHub actions #92

Open mk-pmb opened 4 years ago

mk-pmb commented 4 years ago

Hi! Could you maybe add a daily CI task that builds default config images on Github Actions? That way people can have shared grounds for testing basic NodeMCU functionality, separating web form filling issues from docker build issues. As a side bonus you have daily degradation tests. I've set up something like that already but it uses an overly feature-ladden build method, so you'll probably have easier trust in a minimal version on your own repo. If you like I can try and make a PR for it.

mk-pmb commented 4 years ago

web form filling issues

Turns out my current problem of "It's pointless to select that many modules," was indeed one of those. I fill the form like this (screenshot) but somehow firefox comes up with lots more modules (screenshot). I'll try in another browser.

Update: Seems like the repeated checkboxes are from the hidden feature fieldsets of branches other than the selected.

Update: With the invisible fieldsets removed from the DOM, I got a step further to "The email is invalid or not legit e.g. from a banned provider. Go back and try again." Not sure why you'd want to ban guerrillamail.com, but I'll try others then. Would be nice if you could warn about the banned providers upfront in the entry form.