search

marcgibbons / django-rest-framework-docs

An inventory tool for Django Rest Framework v2 API endpoints
BSD 2-Clause "Simplified" License
95 stars 34 forks source link

django-rest-framework-docs doesn't work with latest version of django-rest-framework #14

Closed swistakm closed 11 years ago

swistakm commented 11 years ago

Doesn't work with 2.3.4.

I've seen that @avinash240 already fixed it in his fork. Maybe it's worth merging?

avinash240 commented 11 years ago

There isn't much work to do to make this backwards compatible with older versions of django rest framework. The only other issue I've found is there are a lot of calls in the original code of 'cls_instance.' I'm not sure how that works, I couldn't get it to work myself and switch to using .cls. This is my primary reason for not sending a pull request, if the author can clear that up I'll gladly send the pull request.

marcgibbons commented 11 years ago

Thanks for this - will look into it.

marcgibbons commented 11 years ago

Dear gents, I just pushed a new version using avinash240's fork. Added some conditions to check if the instances use 'cls' or 'cls_instance' as to work with both DRF <= v2.3. Let me know if it works out or if anything broke!

Many thanks, Marc

avinash240 commented 11 years ago

Any way I can get a contributor mention on this?

Marlon

On Sat, Jun 1, 2013 at 8:01 PM, Marc Gibbons notifications@github.comwrote:

Dear gents, I just pushed a new version using avinash240's fork. Added some conditions to check if the instances use 'cls' or 'cls_instance' as to work with both DRF <= v2.3. Let me know if it works out or if anything broke!

Many thanks, Marc

— Reply to this email directly or view it on GitHubhttps://github.com/marcgibbons/django-rest-framework-docs/issues/14#issuecomment-18799331 .

marcgibbons commented 11 years ago

Totally! Thanks for your help, Marc On 13-06-01 10:59 PM, Marlon Bailey wrote:

Any way I can get a contributor mention on this?

Marlon

On Sat, Jun 1, 2013 at 8:01 PM, Marc Gibbons notifications@github.comwrote:

Dear gents, I just pushed a new version using avinash240's fork. Added some conditions to check if the instances use 'cls' or 'cls_instance' as to work with both DRF <= v2.3. Let me know if it works out or if anything broke!

Many thanks, Marc

— Reply to this email directly or view it on GitHubhttps://github.com/marcgibbons/django-rest-framework-docs/issues/14#issuecomment-18799331 .

— Reply to this email directly or view it on GitHub https://github.com/marcgibbons/django-rest-framework-docs/issues/14#issuecomment-18801000.