search

marcglasberg / async_redux

Flutter Package: A Redux version tailored for Flutter, which is easy to learn, to use, to test, and has no boilerplate. Allows for both sync and async reducers.
Other
234 stars 40 forks source link

Support connectivity_plus 6.x #153

Closed kuhnroyal closed 6 months ago

kuhnroyal commented 7 months ago

The version has a breaking change with which it now supports multiple connectivity results.

While I like the general idea of the new connectivity check in async_redux, this also introduces a hard dependency. I wonder if it would be better to publish this as a separate package like async_redux_connectivity.

marcglasberg commented 7 months ago

It was not supposed to be a breaking change. Could you please explain how is it breaking for you?

Em qua., 10 de abr. de 2024 07:02, Peter Leibiger @.***> escreveu:

The version has a breaking change with which it now supports multiple connectivity results.

While I like the general idea of the new connectivity check in async_redux, this also introduces a hard dependency. I wonder if it would be better to publish this as a separate package like async_redux_connectivity.

— Reply to this email directly, view it on GitHub https://github.com/marcglasberg/async_redux/issues/153, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFW5DRWJ7F6Y3PQONLHSH3Y4US65AVCNFSM6AAAAABGAJVSGWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTKNBTGM3TEOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kuhnroyal commented 7 months ago

I am talking about the new version of connectivity_plus which contains a breaking release.

kuhnroyal commented 7 months ago

This is kind of getting more important every day, since only connectivity_plus: ^6.0.1 contains the Apple privacy manifest changes.

marcglasberg commented 7 months ago

Sorry, I am travelling and without my laptop. I can solve this next week when I come back. Meanwhile, can you set a dependency override in your pubspec.yaml?

Em qui., 18 de abr. de 2024 02:31, Peter Leibiger @.***> escreveu:

This is kind of getting more important every day, since only connectivity_plus: ^6.0.1 contains the Apple privacy manifest changes.

— Reply to this email directly, view it on GitHub https://github.com/marcglasberg/async_redux/issues/153#issuecomment-2063320662, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFW5DU47BWRRTZXLV6O4OLY56AFFAVCNFSM6AAAAABGAJVSGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGMZDANRWGI . You are receiving this because you commented.Message ID: @.***>

kuhnroyal commented 7 months ago

All good, no worries. The problem is a breaking change, connectivity_plus now returns a list of ConnectivityResult which leads to compile errors. Meaning you can have a bluetooth, ethernet and whatever connection at the same time.

marcglasberg commented 7 months ago

I see. Ok, next week it will be fixed.

Em sex., 19 de abr. de 2024 08:12, Peter Leibiger @.***> escreveu:

All good, no worries. The problem is a breaking change, connectivity_plus now returns a list of ConnectivityResult which leads to compile errors. Meaning you can have a bluetooth, ethernet and whatever connection at the same time.

— Reply to this email directly, view it on GitHub https://github.com/marcglasberg/async_redux/issues/153#issuecomment-2066674741, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFW5DWDYA2OMMHY2LBRRY3Y6EQ4XAVCNFSM6AAAAABGAJVSGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWGY3TINZUGE . You are receiving this because you commented.Message ID: @.***>

marcglasberg commented 6 months ago

See version 23.0.0. Thanks, and sorry for the delay.

kuhnroyal commented 6 months ago

Thanks so much!

kuhnroyal commented 6 months ago

Can you also bump the hooks package when you get a chance? Started using this, really helpful!

marcglasberg commented 6 months ago

@kuhnroyal See flutter_hooks_async_redux: ^2.0.0

https://pub.dev/packages/flutter_hooks_async_redux