search

marchaos / jest-mock-extended

Type safe mocking extensions for Jest https://www.npmjs.com/package/jest-mock-extended
MIT License
845 stars 59 forks source link

bug: mockReset doesn't work well with calledWith #22 #24

Closed regevbr closed 4 years ago

regevbr commented 4 years ago

fix #22

regevbr commented 4 years ago

@marchaos can you please CR?

regevbr commented 4 years ago

Please notice I updates the jest types package as they include the getMockImplementation function typings required in the change

regevbr commented 4 years ago

the tests are failed because of coveralls, and I can't restart it

regevbr commented 4 years ago

@bbarry I have fixed your suggestion

regevbr commented 4 years ago

@marchaos can you please CR?

marchaos commented 4 years ago

Hey - going to look at this today, and you're other one too. Sorry for the slowness - things have been a bit hectic lately

regevbr commented 4 years ago

Hi @marchaos thanks for taking the time and letting me know. Looking forward to your feedback

regevbr commented 4 years ago

Hi @marchaos, when are you expected to go over my PRs?

regevbr commented 4 years ago

Hi @marchaos, I know you are busy, but is there a chance you can go over this PR?

regevbr commented 4 years ago

@marchaos can you please CR?

regevbr commented 4 years ago

Thanks @marchaos