search

marchaos / react-virtualized-sticky-tree

A React component for efficiently rendering tree like structures with support for position: sticky
MIT License
151 stars 12 forks source link

Update component lifecycle methods #14

Closed fraserdrops closed 4 years ago

fraserdrops commented 4 years ago

This library uses lifecycle methods such as componentWillMount which are no longer recommended to use. This generates warnings for users such as below:

image

Would it be possible to update the lifecycle methods as recommended?

marchaos commented 4 years ago

Hey. Sure, I'll update these. I want to switch to hooks at some point, but will add the prefix in the meantime.

On Thu, 12 Dec 2019, 01:59 Fraser McIntosh, notifications@github.com wrote:

This library uses lifecycle methods such as componentWillMount which are no longer recommended to use. This generates warnings for users such as below:

[image: image] https://user-images.githubusercontent.com/18131282/70675939-72fa7700-1cef-11ea-9fb0-e54e4626be2c.png

Would it be possible to update the lifecycle methods as recommended?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/marchaos/react-virtualized-sticky-tree/issues/14?email_source=notifications&email_token=AAVBY6KUREG5Z5PQ4CFENRLQYGLG7A5CNFSM4JZXZJGKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H75STHA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVBY6K5L37Q5Y54P5M4R63QYGLG7ANCNFSM4JZXZJGA .

fraserdrops commented 4 years ago

Brilliant, thanks!

marchaos commented 4 years ago

Will be fixed in the next release (tonight)