Issue while using scrollNodeIntoView for implementing jump to functionality

marchaos / react-virtualized-sticky-tree

A React component for efficiently rendering tree like structures with support for position: sticky

MIT License

151 stars 12 forks source link

Issue while using scrollNodeIntoView for implementing jump to functionality #15

Closed sanketjo96 closed 4 years ago

sanketjo96 commented 4 years ago

Came across the weird case where calling scrollNodeIntoView after manual scrolling hides row randomly. The row gets rendered again when scroll.

Created a below reduce test case to showcase the issue - Sandbox - reduce test case

Steps to reproduce
1. Click on button "jump to child 10" >Auto scroll should move you at bottom > Everything works fine.
2. Scroll back top and then scroll down till end manually
3. Now, click on "jump to child 10" > See Row "Child 8" gets disappeared

This looks strange. One observation though, if you increase the overscanRowCount to say 20 (in above case) it stops. Could you please have a look here ?.

I will update if i see any unusual thing.

sanketjo96 commented 4 years ago

Hey Marc - did you get chance to go over this ?

marchaos commented 4 years ago

Hey. Not yet sorry. I'm back at work on Monday so should have some time then

On Fri, 27 Dec 2019, 08:32 sanketjo96, notifications@github.com wrote:

Hey Marc - did you get chance to go over this ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/marchaos/react-virtualized-sticky-tree/issues/15?email_source=notifications&email_token=AAVBY6LM3KUA2W6DKUA3IR3Q2W4RPA5CNFSM4J6WWIR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHWZ5WY#issuecomment-569220827, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVBY6IF5RLZLUUAHXVH7ETQ2W4RPANCNFSM4J6WWIRQ .

sanketjo96 commented 4 years ago

Did you get a chance to have a look marc ?

marchaos commented 4 years ago

Hey @sanketjo96. Thanks for the sandbox - I can see that node 8 is actually removed from the dom, so should be easy find out what's going on.

sanketjo96 commented 4 years ago

Thanks for reply. Could you please let me know if/when you are planning on fix ?

marchaos commented 4 years ago

Hey @sanketjo96. I haved fixed this in branch issue_15. Just sorting out a release.

marchaos commented 4 years ago

I've pushed a new version. Can you try 2.1.26 ? https://codesandbox.io/s/xenodochial-wu-feq0t?from-embed

sanketjo96 commented 4 years ago

Thanks Marc for fix. Wll try out with new version and will notify here. Thanks a lot again

sanketjo96 commented 4 years ago

Hey Marc, I am done with initial round of testing and found a bit different issue. I am unable to scroll back up using scrollNodeIntoView

Please have a look at - Sandbox

Click on "Jump to child 3" it works fine
Click on "jump to child 3" again. Everything looks good and original reported issue is no longer present
Now click on "jump to child1" > Unable to jump on Child 1.

This worked well when I synced lib back to 2.1.25

Can you please have a look ? I guess we are always returning early when we reach to max scroll position. May be we need to consider the case when user wanted to scroll back up.

marchaos commented 4 years ago

Hey. Yes, will take a look. If you can, I'll get a branch for you to test before releasing.

sanketjo96 commented 4 years ago

Yes. That will make it safe. Thanks for quick response.

sanketjo96 commented 4 years ago

Hey - Please share the branch once you commit the change. Thanks.

marchaos commented 4 years ago

See comments in other issue - looks to be border related.