marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
40 stars 47 forks source link

fix: this week newest items appear at the bottom #486

Closed sajdakabir closed 1 week ago

sajdakabir commented 1 week ago

What does this PR do?

this week newest items appear at the bottom

https://github.com/user-attachments/assets/5bd25cb7-eea2-4205-ad71-c9bc69248f45

Fixes:

Mandatory Tasks:

How should this be tested?

Environment Setup:

Test Data Requirements:

Checklist:

coderabbitai[bot] commented 1 week ago
πŸ“ Walkthrough ## Walkthrough The pull request introduces changes to two primary files: `item.service.js` and `cycle.store.ts`. In `item.service.js`, the `getThisWeekItemsByDateRange` function is updated to include sorting by the `createdAt` field in ascending order, and the function name `getAllitems` is corrected to `getAllItems`. In `cycle.store.ts`, the `createItem` method's logic is modified to append new items to the `thisWeek` array instead of prepending them. Additionally, error messages in several fetch methods are corrected for clarity. ## Changes | File Path | Change Summary | |---------------------------------------------|-----------------------------------------------------------------------------------------------------| | apps/backend/src/services/lib/item.service.js | - Updated `getThisWeekItemsByDateRange` to sort items by `createdAt` in ascending order.
- Corrected function name from `getAllitems` to `getAllItems`. | | apps/frontend/src/lib/store/cycle.store.ts | - Modified `createItem` to append items to `thisWeek` instead of prepending.
- Corrected error messages from "unknow" to "unknown" in multiple fetch methods. | ## Possibly related PRs - **#363**: Modifies the `item.service.js` file, specifically the `getThisWeekItems` function, which is closely related to the modified `getThisWeekItemsByDateRange`. - **#400**: Introduces a new controller function `getThisWeekItemsByDateRangeController`, directly utilizing the modified `getThisWeekItemsByDateRange` service function. - **#418**: Enhances the `CustomKanban` component to include functionality for adding items in the "this-week" section, relevant to item retrieval changes. - **#422**: Adds a new controller function for retrieving favorite items, relating to overall item management. - **#464**: Involves modifications to the `item.model.js` file, indirectly relating to item retrieval and management. ## Suggested labels `ready to be merged` ## Suggested reviewers - madhav-relish > πŸ‡ In the code where changes flow, > Items sorted in a neat row. > From prepend to append, they now align, > With error messages clear and fine. > A hop, a skip, to merge we go, > For better code, let’s make it glow! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.