search

marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 50 forks source link

fix: editor save - inbox, today, meetings, this week #488

Closed deewakar-k closed 4 weeks ago

deewakar-k commented 4 weeks ago

What does this PR do?

Fixes:

Mandatory Tasks:

How should this be tested?

Environment Setup:

Test Data Requirements:

Checklist:

coderabbitai[bot] commented 4 weeks ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request introduce several enhancements across multiple components, including `InboxExpandedItem`, `ThisWeekExpandedItem`, `TodayTextArea`, and `MeetNotes`. New interfaces `EditedItem` and `TimeoutRefs` are defined to improve state management and timeout handling. The components now utilize a `SAVE_DELAY` constant for managing save operations. Key functions are refactored to improve clarity and performance, including the addition of error handling in save operations. The debounce timing for the `saveJournal` function in `TodayTextArea` is also adjusted to optimize save timing. ## Changes | File Path | Change Summary | |----------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `apps/frontend/src/components/Inbox/InboxExpandedItem.tsx` | Added `EditedItem` and `TimeoutRefs` interfaces, introduced `SAVE_DELAY`, updated state management, refactored save and content handling functions with error handling. | | `apps/frontend/src/components/ThisWeek/ThisWeekExpandedItem.tsx` | Added `EditedItem` and `TimeoutRefs` interfaces, introduced `SAVE_DELAY`, updated state management, refactored save functionality with improved clarity and maintainability. | | `apps/frontend/src/components/TodayTextArea.tsx` | Reduced debounce timing for `saveJournal` from 2000ms to 500ms. | | `apps/frontend/src/components/meetings/MeetNotes.tsx` | Added `EditedItem` and `TimeoutRefs` interfaces, introduced `SAVE_DELAY`, reorganized state variables, refactored save logic and textarea handling for clarity. | ## Possibly related PRs - **#388**: Changes in the `InboxExpandedItem` component introducing a `TextEditor`, similar to modifications in `ThisWeekExpandedItem`. - **#449**: Introduces a `handleTextareaKeyDown` function for managing keyboard interactions in text areas. - **#469**: Aligns with changes to item title handling in `InboxExpandedItem`, introducing the `truncateString` function for UI constraints. - **#420**: Modifications to the `InboxItems` component to streamline item status management. - **#418**: Enhances functionality for adding items in the `CustomKanban` component, related to item management improvements. - **#377**: Focuses on enhancing item handling and user experience across components, resonating with updates in the main PR. ## Suggested labels `ready to be merged` ## Suggested reviewers - madhav-relish - sajdakabir - oliursahin ## Poem > 🐇 In the meadow where rabbits play, > Changes hop along the way. > With edits made and delays set, > Our inbox blooms, no need to fret! > A tale of items, neat and bright, > Saving swiftly, day and night. 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.