marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 49 forks source link

fix: editor tasklist #503

Closed deewakar-k closed 3 weeks ago

deewakar-k commented 3 weeks ago

What does this Pr do?

Fixes:

Mandatory Tasks:

How should this be tested?

Environment Setup: ( if applicable)

Checklist:

coderabbitai[bot] commented 3 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough ## Walkthrough This pull request includes updates to the GitHub pull request template, introducing a more casual tone and reformatting sections. It also adds new workflows for managing pull requests targeting the `preview` branch, including a synchronization check and a build check. Additionally, various components in the application have been modified, including changes to item models, services, and UI components, enhancing functionality, state management, and styling. ## Changes | File Path | Change Summary | |----------------------------------------------------|-----------------------------------------------------------------------------------------------------| | `.github/pull_request_template.md` | Updated formatting and wording; changed header, reformatted checklist, added new items. | | `.github/workflows/pr-build-update-check.yml` | Deleted workflow for managing PRs against the `preview` branch. | | `.github/workflows/pr-check.yml` | Added new workflow for build and sync checks on PRs targeting the `preview` branch. | | `.github/workflows/preview update check.yml` | Introduced new workflow to check all PRs against the `preview` branch on push events. | | `apps/backend/src/models/lib/item.model.js` | Changed default value casing for `type` field; standardized quotes for `lastVisitedSpace`. | | `apps/backend/src/services/lib/item.service.js` | Added sorting to `getThisWeekItemsByDateRange` function to return items in ascending order. | | `apps/frontend/src/app/(app)/inbox/page.tsx` | Modified JSX structure; updated class attributes for styling. | | `apps/frontend/src/components/Inbox/InboxAddItem.tsx` | Removed `isValidUrl` function and `ItemData` interface; adjusted state management and error handling. | | `apps/frontend/src/components/Inbox/InboxExpandedItem.tsx` | Replaced `Icon` with `Image`; added new state management and enhanced auto-save functionality. | | `apps/frontend/src/components/Inbox/InboxItems.tsx` | Updated imports and state management; simplified item handling and rendering logic. | | `apps/frontend/src/components/Inbox/InboxPage.tsx` | Reduced imports; altered layout and class names for responsiveness. | | `apps/frontend/src/components/Sidebar/SidebarFavorites.tsx` | Adjusted `Sparkle` component size handling; refined toggle state management. | | `apps/frontend/src/components/Sidebar/SidebarMain.tsx` | Updated icon size handling for `Inbox` and `Calendar` links. | | `apps/frontend/src/components/ThisWeek/ThisWeekExpandedItem.tsx` | Introduced new interfaces for better state management; improved saving logic. | | `apps/frontend/src/components/meetings/MeetNotes.tsx` | Enhanced state management and saving logic; added new interfaces for edited items. | | `apps/frontend/src/hooks/useEditor.hook.ts` | Modified `TaskList` extension configuration with additional properties. | | `apps/frontend/src/lib/@types/Items/Cycle.ts` | Removed `setCurrentItem` method; added `deleteItem` method to `CycleItemStore` interface. | | `apps/frontend/src/lib/store/cycle.store.ts` | Enhanced error handling; added `deleteItem` method for item deletion in the store. | | `apps/frontend/src/styles/tiptap.css` | Updated styles for task lists in `.tiptap.ProseMirror`, enhancing visual presentation. | ## Possibly related PRs - **#476**: The changes in the main PR regarding the pull request template updates are related to this PR, which also modifies the pull request template, enhancing its structure and clarity. - **#489**: This PR also updates the pull request template, making changes to section headers and checklist formatting, aligning with the changes made in the main PR. ## Suggested labels `ready to be merged` ## Suggested reviewers - oliursahin > 🐰 In the land of code where changes bloom, > A template revamped, dispelling the gloom. > With workflows anew, and items refined, > Our project's a treasure, beautifully aligned. > So hop along, dear coder, let’s merge with cheer, > For every small change brings us closer, my dear! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 3 weeks ago

Hey there! 👋

We require pull request titles to follow the Conventional Commits specification.

Valid types:

Format: type: description

Error details:

No release type found in pull request title "Fix/editor tasklist". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - build
 - ci
 - chore
 - revert