search

marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 49 forks source link

feat: Google Calendar access revoked and webhook removed #530

Closed sajdakabir closed 3 weeks ago

sajdakabir commented 3 weeks ago

What does this PR do?

Google Calendar access revoked and webhook removed Fixes:

Mandatory Tasks:

How should this be tested?

Environment Setup: ( if applicable)

Checklist:

coderabbitai[bot] commented 3 weeks ago
📝 Walkthrough ## Walkthrough The changes in this pull request primarily involve the integration with Google Calendar services across several files. Key modifications include the removal of the `getGoogleCalendarOAuthAuthorizationUrl` function and the introduction of new functions for revoking access and managing webhooks. The `redirectGoogleCalendarOAuthLoginController` has been removed, indicating a shift in OAuth handling. Additionally, a new `metadata` field has been added to the `UserSchema` to accommodate flexible data storage related to Google Calendar integrations. ## Changes | File Path | Change Summary | |---------------------------------------------------|--------------------------------------------------------------------------------------------------------------------| | `apps/backend/src/controllers/integration/calendar.controller.js` | - Removed: `redirectGoogleCalendarOAuthLoginController`
- Added: `revokeGoogleCalendarAccessController`
- Updated: `setUpCalendarWatch` to include `user` parameter | | `apps/backend/src/models/core/user.model.js` | - Added: `metadata` field of type `Schema.Types.Mixed` in `googleCalendar` object within `UserSchema` | | `apps/backend/src/routers/integration/calendar.route.js` | - Added: Route for revoking access at `/revoke-access/` mapped to `revokeGoogleCalendarAccessController`
- Removed: Route for connecting to Google Calendar using `redirectGoogleCalendarOAuthLoginController` | | `apps/backend/src/services/integration/calendar.service.js` | - Removed: `getGoogleCalendarOAuthAuthorizationUrl`
- Updated: `setUpCalendarWatch` to include `user`
- Added: `revokeGoogleCalendarAccess` and `removeGoogleCalendarWebhook` functions | ## Possibly related PRs - **#380**: The changes in `calendar.service.js` regarding the removal of the `getGoogleCalendarOAuthAuthorizationUrl` function and the addition of `revokeGoogleCalendarAccess` are related to the modifications in the same file in this PR, which also focuses on Google Calendar integration. - **#399**: This PR introduces a check for the Google Calendar connection before making API calls, which aligns with the changes in the main PR that enhance the management of Google Calendar integrations, particularly in handling user-specific data and access. ## Suggested reviewers - deewakar-k - joaorceschini > 🐇 In the garden, hopping free, > Google Calendar's now a glee! > Revoked access, webhooks too, > With metadata, we start anew. > A spring of changes, fresh and bright, > Integration's path is now in sight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.