sajdakabir commented 3 weeks ago

What did you ship?

feedback making overdue items done shows in due dates today

Fixes:

[ ] #XXX (GitHub issue number)
[ ] MAR-294 (Linear issue number - should be visible at the bottom of the GitHub issue description)

Checklist:

[ ] I have self-reviewed the code (A decent size PR without self-review might be rejected)
[ ] I pinky swear that my codes gonna work as I have testing every possible scenario.
[ ] I ignored Coderabbit suggestion because it does not make any sense.
[ ] I took Coderabbit suggestion under consideration as some of it makes sense.
[ ] I have commented my code, particularly in hard-to-understand areas.

OR:

[ ] shut up and let me cook.

coderabbitai[bot] commented 3 weeks ago

📝 Walkthrough

## Walkthrough The pull request introduces modifications to the `ItemSchema` in `item.model.js` by adding a `completedAt` field to track when an item is marked as completed. The `pre("save")` and `pre("findOneAndUpdate")` middleware are updated to manage this new field appropriately. Additionally, the `getUserTodayItems` and `getUserItemsByDate` functions in `item.service.js` are altered to include `completedAt` in the item retrieval queries, allowing for more flexible date-based filtering. ## Changes | File | Change Summary | |-----------------------------------------|---------------------------------------------------------------------------------------------------| | apps/backend/src/models/lib/item.model.js | Added `completedAt` field of type `Date` to `ItemSchema` and updated middleware to manage it. | | apps/backend/src/services/lib/item.service.js | Modified `getUserTodayItems` and `getUserItemsByDate` to include `completedAt` in item retrieval queries; removed `getOverdueItemsByDate`. | | apps/backend/src/controllers/core/user.controller.js | Removed import of `getOverdueItemsByDate` and updated logic in `getUserItemsByDateController` to use `getUserOverdueItems`; enhanced user profile response structure. | ## Assessment against linked issues | Objective | Addressed | Explanation | |-----------------------------------------------------------------------------------------------|-----------|---------------------------------------| | If I have an overdue item due date 1 nov, that shows in 2nd nov and I make it done, it should show in 2nd nov's today not 1st nov's today (MAR-294). | ✅ | | ## Possibly related issues - **marchhq/march#521**: The changes in this PR directly address the issue of overdue items showing incorrectly, as they allow completed items to be included in the current date's retrieval. ## Possibly related PRs - **#363**: The changes in `item.service.js` regarding the handling of overdue items are related to the main PR's updates to the `completedAt` field, as both involve managing item states based on dates. - **#377**: This PR introduces modifications to the `DropDownItems` component that involve overdue date handling, which connects to the main PR's focus on managing completion timestamps. - **#400**: Although primarily focused on GitHub integration, this PR's changes in the controller could relate to how items are fetched and displayed, potentially interacting with the completion state introduced in the main PR. - **#422**: The addition of the `isFavourited` field in the `item.model.js` file may not directly relate to the completion state but indicates ongoing modifications to the item schema, which is relevant to the main PR's changes. - **#504**: The structural changes to the `ItemSchema` in this PR, particularly regarding cycle dates, are relevant as they reflect ongoing modifications to the item model that could interact with the completion tracking introduced in the main PR. - **#512**: Similar to #504, this PR's changes to the `ItemSchema` regarding cycle dates are relevant to the main PR's updates to item management. - **#519**: The modifications to the `getThisWeekItemsByDateRange` function in this PR relate to how items are queried based on their completion state, which connects to the main PR's focus on managing item states. - **#533**: This PR addresses changes related to cycle jobs, which may indirectly relate to the management of item states and completion tracking introduced in the main PR. > 🐇 "In the garden where items bloom, > A date for completion dispels the gloom. > With `completedAt` now in sight, > Overdue tasks can shine so bright! > Retrieve them all, both done and due, > A hop of joy for me and you!" 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 3 weeks ago

Hey there! 👋

We require pull request titles to follow the Conventional Commits specification.

Valid types:

feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing or correcting existing tests
build: Changes that affect the build system or external dependencies
ci: Changes to CI configuration files and scripts
chore: Other changes that don't modify src or test files
revert: Reverts a previous commit

Format: type: description

Error details:

No release type found in pull request title "Sajdakabir/mar 294 feedback making overdue items done shows in due dates today". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - build
 - ci
 - chore
 - revert

marchhq / march

Sajdakabir/mar 294 feedback making overdue items done shows in due dates today #535

What did you ship?

Checklist:

OR: