deewakar-k commented 3 weeks ago

What did you ship?

Fixes:

[x] #536 (GitHub issue number)
[x] MAR-303 (Linear issue number - should be visible at the bottom of the GitHub issue description)

Checklist:

[x] I have self-reviewed the code (A decent size PR without self-review might be rejected)
[x] I pinky swear that my codes gonna work as I have testing every possible scenario.
[x] I ignored Coderabbit suggestion because it does not make any sense.
[x] I took Coderabbit suggestion under consideration as some of it makes sense.
[x] I have commented my code, particularly in hard-to-understand areas.

OR:

[x] shut up and let me cook.

coderabbitai[bot] commented 3 weeks ago

📝 Walkthrough

## Walkthrough The changes in this pull request involve modifications to the layout and styling of the `TodayPage`, `TodayMeetings`, and `TodayTextArea` components. Key updates include the removal of the `overflow-y-hidden` class in `TodayPage`, the addition of the `no-scrollbar` class for improved scroll behavior, and adjustments to height and width constraints. The `TodayMeetings` component received a left margin modification, while `TodayTextArea` now includes an `overflow-scroll` class to enable scrolling. These adjustments enhance the visual layout and usability of the components. ## Changes | File Path | Change Summary | |---------------------------------------------|---------------------------------------------------------------------------------------------------| | `apps/frontend/src/components/Today/TodayPage.tsx` | Simplified `main` class; added `no-scrollbar` class and height/width constraints for sections. Increased width of `ShowAgenda` section. Updated `TodayMeetings` rendering with scroll capabilities. | | `apps/frontend/src/components/TodayMeetings.tsx` | Modified `

` class to include `overflow-scroll`, enabling scrolling for content overflow. | | `apps/frontend/src/components/TodayItems.tsx` | Updated `div` class to include `no-scrollbar max-h-[90vh] overflow-y-auto`, enhancing scrolling behavior. Clarified error handling comment. | ## Assessment against linked issues | Objective | Addressed | Explanation | |---------------------------------------------------|-----------|--------------------------------------| | Add independent scrolls for blocks in today board (#536, MAR-303) | ✅ | | ## Possibly related PRs - **#364**: The changes in `TodayItems.tsx` involve restructuring how items are accessed from the store, which is relevant to the modifications in the main PR that also affects the layout and rendering of items. - **#365**: The changes in `TodayItems.tsx` and the addition of the `no-scrollbar` class in the `InboxItems.tsx` are related to the styling and scrolling behavior enhancements in the main PR. - **#390**: The modifications in `TodayMeetings.tsx` regarding the rendering structure and layout improvements align with the layout changes made in `TodayPage.tsx` in the main PR. - **#488**: The changes in `TodayTextArea.tsx` to enhance the save functionality are relevant to the overall improvements in user interaction and functionality in the main PR. - **#518**: The introduction of the `RescheduleCalendar` component in `InboxItems.tsx` relates to the enhancements in the layout and functionality of the `TodayPage.tsx` in the main PR. ## Suggested labels `need for alpha launch`, `ready to be merged` ## Suggested reviewers - madhav-relish - joaorceschini - oliursahin > 🐇 In the land of today, where meetings abound, > With scrolls and layouts, new joy can be found. > Text areas flowing, agendas in sight, > Our components are ready, all styled just right! > So hop on this change, let the features unfold, > In the world of our app, watch the magic behold! ✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 3 weeks ago

Hey there! 👋

We require pull request titles to follow the Conventional Commits specification.

Valid types:

feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing or correcting existing tests
build: Changes that affect the build system or external dependencies
ci: Changes to CI configuration files and scripts
chore: Other changes that don't modify src or test files
revert: Reverts a previous commit

Format: type: description

Error details:

Unknown release type "refactor" found in pull request title "refactor: today scroll". 

Available types:
 - feat
 - fix
 - docs
 - ui
 - refac
 - perf
 - test
 - build
 - ci
 - chore
 - revert

marchhq / march

refactor: today scroll #543

What did you ship?

Checklist:

OR: