marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 48 forks source link

refac: today agenda api #560

Closed deewakar-k closed 2 weeks ago

deewakar-k commented 2 weeks ago

What did you ship?

Fixes:

Checklist:

OR:

coderabbitai[bot] commented 2 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces significant changes to the calendar and meeting management functionalities within the application. Key modifications include renaming and restructuring functions to focus on date-specific event retrieval, removing webhook handling, and simplifying access management for Google Calendar. The meeting controller has been updated to facilitate meeting creation while removing outdated retrieval methods. Additionally, the frontend components and type definitions have been adjusted to reflect these changes, particularly transitioning from a `Meeting` model to an `Event` model. ## Changes | File Path | Change Summary | |-----------------------------------------------|---------------------------------------------------------------------------------------------------------| | `apps/backend/src/controllers/integration/calendar.controller.js` | Renamed `getGoogleCalendarEvents` to `getGoogleCalendarEventsByDate`, removed webhook handling functions. | | `apps/backend/src/controllers/page/meeting.controller.js` | Added `createMeetingController`, renamed `recentUpcomingMeetingController` to `getMeetingsController`, removed `getUpcomingMeetingsController`. | | `apps/backend/src/index.js` | Removed webhook handling imports and route definitions for calendar events. | | `apps/backend/src/jobs/calendar.job.js` | Deleted the entire file, which handled jobs related to Google Calendar events. | | `apps/backend/src/loaders/bullmq.loader.js` | Removed `calendarQueue` instantiation and export. | | `apps/backend/src/models/core/user.model.js` | Removed `metadata` field from `googleCalendar` in `UserSchema`. | | `apps/backend/src/routers/integration/calendar.route.js` | Updated route to fetch events by date, reflecting the renaming of the controller. | | `apps/backend/src/routers/lib/space.route.js` | Added new route for creating meetings, removed routes for upcoming meetings. | | `apps/backend/src/services/integration/calendar.service.js` | Renamed function for fetching events, added new function for retrieving meetings by date, removed webhook functions. | | `apps/backend/src/services/page/meeting.service.js` | Added `createMeeting` function, redefined `getMeeting`, removed `recentUpcomingMeeting` and `getUpcomingMeetings`. | | `apps/frontend/src/components/TodayMeetings.tsx` | Changed references from `Meeting` to `Event`, updated related logic. | | `apps/frontend/src/hooks/useMeetings.ts` | Updated API endpoint for fetching meetings to reflect backend changes. | | `apps/frontend/src/lib/@types/Items/event.ts` | Renamed `Meeting` interface to `Event`, updated properties to be optional where applicable. | ## Possibly related PRs - **#380**: Modifications to the `calendar.service.js` file related to Google Calendar event handling. - **#466**: Introduces functions for fetching Google Calendar meetings, which is directly related to the main PR's changes in the calendar controller for managing Google Calendar events. - **#544**: The addition of the `getGoogleCalendarMeetingsByDateController` function in this PR is directly related to the main PR's changes, which also involve fetching meetings based on specific dates. - **#557**: This PR focuses on enhancing item retrieval logic, including handling deleted items, which may relate to the overall management of calendar events and their statuses in the main PR. ## Suggested labels `ready to be merged` ## Suggested reviewers - sajdakabir - joaorceschini ## Poem > 🐰 In the garden of code, changes bloom bright, > Events now dance in the soft moonlight. > Meetings transformed, new paths we tread, > With every update, new stories are spread. > From webhook whispers to dates we embrace, > A joyful leap in this digital space! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.