marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 49 forks source link

refac: item expand modal component for inbox, today and this week #581

Closed joaorceschini closed 1 week ago

joaorceschini commented 1 week ago

What did you ship?

item expand modal component for inbox, today and this week

Fixes:

Checklist:

OR:

coderabbitai[bot] commented 1 week ago
πŸ“ Walkthrough ## Walkthrough The pull request introduces several modifications across multiple components in the application. Key changes include updates to the `ThisWeek` and `InboxPage` components, where class attributes and component imports have been altered. The `CustomKanban` and `ThisWeekExpandedItem` components have been removed, while a new `ThisWeekItems` component has been added. The `ItemExpandModal` replaces `InboxExpandedItem`. Additionally, the `SidebarMain` component now uses `getCurrentWeek` instead of a custom function. The changes improve item management and navigation features within the application. ## Changes | File Path | Change Summary | |-------------------------------------------------|-----------------------------------------------------------------------------------------------------------| | `apps/frontend/src/app/(app)/this-week/page.tsx` | Updated class attributes in `ThisWeek` component to include `overflow-y-auto`, `p-10`, and `pl-5`. | | `apps/frontend/src/components/Inbox/InboxPage.tsx` | Replaced `InboxExpandedItem` with `ItemExpandModal`, updated JSX structure for item count display. | | `apps/frontend/src/components/Sidebar/SidebarMain.tsx` | Removed `getWeekNumber`, imported `getCurrentWeek` for week number calculation. | | `apps/frontend/src/components/ThisWeek/CustomKanban.tsx` | Component removed; previously managed a Kanban board interface. | | `apps/frontend/src/components/ThisWeek/ThisWeekArrows.tsx` | Updated icon imports, modified `onChangeWeek` function to accept "this" as a parameter. | | `apps/frontend/src/components/ThisWeek/ThisWeekExpandedItem.tsx` | Component removed; previously rendered an expanded view for current week items. | | `apps/frontend/src/components/ThisWeek/ThisWeekItems.tsx` | New component added to manage and display items for the current week. | | `apps/frontend/src/components/ThisWeek/ThisWeekPage.tsx` | Updated imports, state management, and item filtering logic; replaced `CustomKanban` with `ThisWeekItems`. | | `apps/frontend/src/components/Today/TodayExpandedItem.tsx` | Enhanced state management and auto-saving logic for item editing. | | `apps/frontend/src/components/Today/TodayItems.tsx` | Replaced `TodayExpandedItem` with `ItemExpandModal` for item expansion. | | `apps/frontend/src/components/atoms/ItemExpandModal.tsx` | Renamed from `InboxExpandedItem`, simplified content state management and rendering logic. | | `apps/frontend/src/components/atoms/ItemList.tsx` | Updated props interface to include new optional properties for handling in-progress items. | | `apps/frontend/src/lib/store/cycle.store.ts` | Enhanced item management logic, updated error handling and method signatures in Zustand store. | ## Possibly related PRs - **#304**: Changes related to the "this week" feature, connected to modifications in the `ThisWeek` component. - **#364**: Involves changes to the `InboxItems` component, relevant to overall item management. - **#377**: Enhancements to the `DropdownItem` component, relevant to item display in `ThisWeek`. - **#381**: Addresses layout adjustments in `ThisWeekPage`, directly related to the main PR. - **#388**: Introduction of a `TextEditor` component relevant to editing functionality in `ThisWeekExpandedItem`. - **#397**: Introduces a new controller function for fetching current week items, relevant to main PR changes. - **#400**: Modifications to `ThisWeekArrows` component related to navigation functionality. - **#418**: Enhances functionality of `CustomKanban`, relevant to the `ThisWeek` component. - **#437**: Focuses on handling cycle dates, relevant to `ThisWeek` functionality. - **#484**: Enhancements to `InboxExpandedItem` deletion functionality, relevant to item management. - **#512**: Changes focus on cycle management, relevant to `ThisWeek` functionality. - **#518**: Introduction of a rescheduling modal directly relevant to item management changes. - **#519**: Modifications to `getThisWeekItemsByDateRange` function relevant to current week handling. - **#539**: Enhancements to `InboxItems`, relevant to overall item management. - **#547**: Changes focus on `TodayMeetings`, potentially related to item management. - **#555**: Modifications to `Sidebar`, relevant to layout and navigation. - **#557**: Enhancements to item retrieval logic, relevant to overall item management. - **#568**: Small fixes in inbox functionality, potentially related to item management. ## Suggested labels `ready to be merged` > πŸ‡ Hop, hop, hooray! > Changes are here today! > With arrows pointing clear, > And items drawing near, > A week to manage and play! > Let’s celebrate this way! πŸŽ‰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.