search

marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 49 forks source link

Revert "refac: item expand modal component for inbox, today and this week" #582

Closed sajdakabir closed 1 week ago

sajdakabir commented 1 week ago

Reverts marchhq/march#581

coderabbitai[bot] commented 1 week ago
📝 Walkthrough ## Walkthrough This pull request introduces significant modifications across various components in the application. Key changes include the renaming of components, the introduction of a new Kanban board for task management, and enhancements to markdown handling in the `InboxExpandedItem`. The `ThisWeek` component's layout has been simplified, and several components have been removed or replaced to streamline functionality. Additionally, error handling and state management improvements have been implemented in the `cycle.store.ts` file, refining item update logic and enhancing clarity in error messages. ## Changes | File Path | Change Summary | |--------------------------------------------------|-----------------------------------------------------------------------------------------------------| | `apps/frontend/src/app/(app)/this-week/page.tsx` | Modified `ThisWeek` component's class attributes, simplifying layout and styling. | | `apps/frontend/src/components/Inbox/InboxExpandedItem.tsx` | Renamed component to `InboxExpandedItem`, added markdown processing, and updated state handling. | | `apps/frontend/src/components/Inbox/InboxPage.tsx` | Replaced `ItemExpandModal` with `InboxExpandedItem`, updated total items count rendering. | | `apps/frontend/src/components/Sidebar/SidebarMain.tsx` | Introduced `getWeekNumber` function, replacing `getCurrentWeek`, and updated sidebar link label. | | `apps/frontend/src/components/ThisWeek/CustomKanban.tsx` | Added a new Kanban board component for task management with drag-and-drop functionality. | | `apps/frontend/src/components/ThisWeek/ThisWeekArrows.tsx` | Updated icon imports and simplified week navigation options. | | `apps/frontend/src/components/ThisWeek/ThisWeekExpandedItem.tsx` | Introduced a new component for editing weekly items with auto-save functionality. | | `apps/frontend/src/components/ThisWeek/ThisWeekItems.tsx` | Deleted the `ThisWeekItems` component, which was responsible for rendering weekly items. | | `apps/frontend/src/components/ThisWeek/ThisWeekPage.tsx` | Updated imports and state management, replaced `ThisWeekItems` with `CustomKanban`. | | `apps/frontend/src/components/Today/TodayExpandedItem.tsx` | Enhanced state management for unsaved changes and auto-saving in the `TodayExpandedItem`. | | `apps/frontend/src/components/Today/TodayItems.tsx` | Replaced `ItemExpandModal` with `TodayExpandedItem`, maintaining overall structure. | | `apps/frontend/src/components/atoms/ItemList.tsx` | Simplified `ItemListProps` interface by removing unused properties and updating method signatures. | | `apps/frontend/src/lib/store/cycle.store.ts` | Refined `updateItem` logic, corrected error messages, and improved overall error handling. | ## Possibly related PRs - **#364**: Changes in the `ThisWeek` component's layout and styling may relate to modifications in the `InboxItems` component. - **#377**: Modifications in the `ThisWeek` component's layout could connect with changes in the `CustomKanban` component. - **#388**: Introduction of a `TextEditor` in `InboxExpandedItem` may relate to changes in `ThisWeekExpandedItem`. - **#397**: Changes in the `ThisWeek` component may connect with a new controller function for fetching items by date range. - **#400**: Modifications in the `ThisWeekArrows` component for navigation may relate to changes in the `ThisWeek` component. - **#418**: Changes in the `ThisWeek` component's layout may relate to enhancements in the `CustomKanban` component. - **#437**: Changes in the `ThisWeek` component's layout may connect with updates in the `cycle.store.ts`. - **#484**: Changes in the `ThisWeek` component's layout may relate to enhancements in the `InboxExpandedItem` component. - **#519**: Changes in the `ThisWeek` component's layout may connect with updates in the `item.service.js`. - **#539**: Changes in the `ThisWeek` component's layout may relate to updates in the `InboxItems` component. - **#556**: Changes in the `ThisWeek` component's layout may connect with updates in the `InboxItems` component. - **#577**: Changes in the `ThisWeek` component's layout may relate to updates in the `InboxPage`. - **#581**: Changes in the `ThisWeek` component's layout may connect with updates in the `InboxPage`. ## Suggested reviewers - **joaorceschini** ## Poem > 🐰 In the garden where changes bloom, > The `ThisWeek` shines, dispelling gloom. > With Kanban boards and arrows bright, > Tasks now dance in joyful flight. > A hop, a skip, the items flow, > In this week’s magic, watch them grow! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 week ago

Hey there! 👋

We require pull request titles to follow the Conventional Commits specification.

Valid types:

Format: type: description

Error details:

No release type found in pull request title "Revert "refac: item expand modal component for inbox, today and this week"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - ui
 - refac
 - perf
 - test
 - build
 - ci
 - chore
 - revert