Revert "refac: reading list"

sajdakabir commented 1 week ago

Reverts marchhq/march#594

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough

## Walkthrough The changes in this pull request involve significant updates to several components within the reading feature of the application. Key modifications include enhancements to the user interface in `AddItemForm.tsx`, structural and functional changes in `ItemsList.tsx`, and the removal of the `ReadingExpandModal.tsx`. Additionally, the `ReadingListComponent.tsx` has been streamlined by eliminating unused state and props. The `ReadingItem` interface has been updated to enforce required properties, and the `ReadingStoreType` interface has been simplified by removing certain methods and properties. Helper functions have also been modified for improved URL validation. ## Changes | File Path | Change Summary | |------------------------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `apps/frontend/src/components/Reading/AddItemForm.tsx` | Updated placeholder text and styling for the input field; increased text size for submission instructions; retained existing functionality and error handling. | | `apps/frontend/src/components/Reading/ItemsList.tsx` | Changed `blockId` to nullable; removed unused props and internal state; introduced `deleteItem` function for asynchronous deletions; updated rendering logic to display `readingItems`. | | `apps/frontend/src/components/Reading/ReadingExpandModal.tsx` | Component removed; previously handled editing of reading items with various state management features. | | `apps/frontend/src/components/Reading/ReadingListComponent.tsx` | Reduced imports and state variables; removed `handleExpand` function; simplified hook usage to only fetch reading list; retained loading and error handling logic. | | `apps/frontend/src/lib/@types/Items/Reading.ts` | Updated `ReadingItem` interface: `type` property made required; removed `status`, `dueDate`, and `cycle` properties. | | `apps/frontend/src/lib/store/reading.store.ts` | Removed `currentItem` and `setCurrentItem` from `ReadingStoreType`; eliminated `updateItem` method; made `title` and `type` required in `ItemData` interface; removed unnecessary properties. | | `apps/frontend/src/utils/helpers.ts` | Updated `isLink` function regex for broader URL validation; modified `truncateString` function to remove optional chaining in length check, which may lead to errors if input is null or undefined. | ## Possibly related PRs - **#594**: Related to UI enhancements in `AddItemForm.tsx`. - **#518**: Involves state management changes in `ItemsList.tsx`. - **#556**: Updates to the `ReadingItem` interface are relevant. - **#484**: Enhancements to item management features. - **#518**: Introduction of `RescheduleCalendar` component. ## Suggested labels `ready to be merged` ## Poem > 🐇 In the garden where the reading grows, > A form to add, where the knowledge flows. > With links and text, now clear and bright, > We hop along, in pure delight! > Items listed, neat and spry, > A simpler way to say goodbye! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 week ago

Hey there! 👋

We require pull request titles to follow the Conventional Commits specification.

Valid types:

feat: A new feature
fix: A bug fix
docs: Documentation only changes
style: Changes that do not affect the meaning of the code
refactor: A code change that neither fixes a bug nor adds a feature
perf: A code change that improves performance
test: Adding missing or correcting existing tests
build: Changes that affect the build system or external dependencies
ci: Changes to CI configuration files and scripts
chore: Other changes that don't modify src or test files
revert: Reverts a previous commit

Format: type: description

Error details:

No release type found in pull request title "Revert "refac: reading list"". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - ui
 - refac
 - perf
 - test
 - build
 - ci
 - chore
 - revert

marchhq / march

Revert "refac: reading list" #605

Review failed