search

marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 48 forks source link

chore: MAR-313 added redirection link to the notification icon #607

Closed tanbirali closed 4 days ago

tanbirali commented 5 days ago

What did you ship?

Modified the getIcon function to do the following

Fixes:

Checklist:

OR:

coderabbitai[bot] commented 5 days ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request enhance the `ItemList` component by modifying the `getSourceIcon` function to accept an additional parameter, `sourceUrl`. This allows the icons for various sources, including "gmail", "githubIssue", "githubPullRequest", and "linear", to be wrapped in a clickable `Link` component from Next.js. The `sourceUrl` is derived from `item.metadata?.url`, improving the interactivity of the icons while keeping the overall structure of the component intact. ## Changes | File | Change Summary | |----------------------------------------|-------------------------------------------------------------------------------------------------| | apps/frontend/src/components/atoms/ItemList.tsx | Updated `getSourceIcon` method signature to accept `sourceUrl`. Added import for `Link` from "next/link". | | apps/backend/.env.example | Updated comments and added new GitHub app configuration variables: `GITHUB_APP_CLIENT_ID`, `GITHUB_APP_CLIENT_SECRET`, `GITHUB_APP_REDIRECT_URL`. | | apps/frontend/.env.local.example | Added new environment variables: `NEXT_PUBLIC_GITHUB_APP_URL`, `NEXT_PUBLIC_LINEAR_CLIENT_ID`, `NEXT_PUBLIC_LINEAR_REDIRECT_URL`. Removed `NEXT_PUBLIC_GITHUB_APP_INSTALLATION_URL`. | ## Assessment against linked issues | Objective | Addressed | Explanation | |---------------------------------------------------------|-----------|--------------------------------------------------| | Provide link for GitHub pulls (584, MAR-313) | ✅ | | > 🐰 In the meadow, icons now gleam, > Clickable links, a coder's dream! > From GitHub pulls, we hop with glee, > With every click, oh, what a spree! > So let’s celebrate, with joy and cheer, > Our icons now lead us, far and near! 🌼✨
📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 01267b7241aa6a88dbc36d3d11af1b366ccbf54c and 5d397bef785ece2cc58acc4c51d47c3e5f4b6164.
📒 Files selected for processing (1) * `apps/frontend/src/components/atoms/ItemList.tsx` (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * apps/frontend/src/components/atoms/ItemList.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sajdakabir commented 5 days ago

@tanbirali the link should open in a new tab

tanbirali commented 4 days ago

Made the requested changes

sajdakabir commented 4 days ago

@tanbirali, this pr has a build error. please fix it.

to test the build error, run pnpm build.

Screenshot 2024-11-18 at 10 28 57 AM

Note: use the Petter format in your code editor; it will likely fix the error.

tanbirali commented 4 days ago

Fixed the errors generated while trying to build.