marchhq / march

building a second brain for next generation makers;
GNU General Public License v3.0
41 stars 49 forks source link

return userTimezone #621

Closed sajdakabir closed 1 week ago

sajdakabir commented 1 week ago

What did you ship?

returning user time zome

Fixes:

Checklist:

OR:

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes involve modifications to the `getGoogleCalendarAccessToken` function and its corresponding controller, `getGoogleCalendarAccessTokenController`. The return values of these functions have been updated to include both `tokenInfo` and `userTimezone`, enhancing the response sent to the client. Additionally, several frontend components have been updated to utilize a new `useTimezone` hook, improving date handling based on the user's timezone. The overall control flow and error handling remain unchanged across all affected methods. ## Changes | File Path | Change Summary | |---------------------------------------------|----------------------------------------------------------------------------------------------------| | `apps/backend/src/controllers/integration/calendar.controller.js` | Updated `getGoogleCalendarAccessTokenController` to return both `tokenInfo` and `userTimezone`. | | `apps/backend/src/services/integration/calendar.service.js` | Modified `getGoogleCalendarAccessToken` to return an object containing both `tokens` and `userTimezone`. | | `apps/frontend/package.json` | Added dependency `js-cookies` with version `^1.0.4`. | | `apps/frontend/src/app/auth/google-calendar/route.ts` | Updated token handling to set `USER_TIMEZONE` cookie based on the response from Google Calendar API. | | `apps/frontend/src/components/Inbox/InboxItems.tsx` | Integrated `useTimezone` hook for date handling and updated date management logic. | | `apps/frontend/src/components/ThisWeek/ThisWeekItems.tsx` | Integrated `useTimezone` hook for date handling and updated date management logic. | | `apps/frontend/src/components/Today/TodayItems.tsx` | Integrated `useTimezone` hook for date handling and updated date management logic. | | `apps/frontend/src/hooks/useTimezone.ts` | Introduced a new custom hook `useTimezone` for managing user timezone. | | `apps/frontend/src/utils/datetime.ts` | Added function `getUserDate` to return dates adjusted for the user's timezone. | ## Possibly related PRs - **#364**: The changes in the `InboxItems.tsx` component regarding the handling of dates and the introduction of the `useTimezone` hook are related to the main PR's focus on managing timezones and date handling in the calendar integration. - **#377**: The modifications to the `DropDownItems.tsx` component, particularly the integration of overdue date handling, align with the main PR's enhancements to date management and user timezone considerations. - **#487**: The updates to the `CustomKanban.tsx` component, specifically regarding the handling of due dates and the introduction of cycle dates, are directly relevant to the main PR's changes in calendar item management. - **#539**: The refactor of the `InboxItems.tsx` component to include cycle dates and the management of rescheduling functionality ties closely to the main PR's focus on enhancing date handling and user interactions. - **#583**: The introduction of the `ItemAdd` component for adding items in the inbox and this week context is related to the main PR's enhancements in item management and user interface improvements. > 🐇 In a world of tokens and time, > A rabbit hops with joy sublime. > With timezone added to the mix, > Our calendar's now a clever fix! > So let us cheer and dance around, > For every change, a treasure found! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 week ago

Hey there! 👋

We require pull request titles to follow the Conventional Commits specification.

Valid types:

Format: type: description

Error details:

No release type found in pull request title "return userTimezone". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - ui
 - refac
 - perf
 - test
 - build
 - ci
 - chore
 - revert