search

marchingband / wvr

Home of WVR, an open source, Arduino compatible, ESP32-based Sample Player and Audio Framework.
GNU General Public License v3.0
67 stars 9 forks source link

Feature Request: Clear Sample #20

Closed jazzbiddy closed 2 years ago

jazzbiddy commented 2 years ago

I'm not sure if I'm missing this somewhere, but it would be great to have a way to remove a sample from a note after you've assigned one to it.

marchingband commented 2 years ago

This is an embarrassingly huge oversight! I will add this ASAP. From a UI perspective, would it make sense to hit delete on the keyboard, to erase the currently selected wav(s) ?

jazzbiddy commented 2 years ago

oh man... great question. Maybe a button added to the right side set of buttons as well as the keyboard key - but you'd need to have a confirm dialog for both, because, you know, accidents happen and it would suck to mistakenly delete the sound.

the button could appear only when the note has a sound assigned.

clear_sound

of course, when cleared, and a sync was performed, the note wouldn't play anything anymore.

marchingband commented 2 years ago

This is implemented in v1.0.9