search

marchingband / wvr

Home of WVR, an open source, Arduino compatible, ESP32-based Sample Player and Audio Framework.
GNU General Public License v3.0
65 stars 9 forks source link

Bug: Loop and ASR-Loop should respect note-off:ignore #67

Closed CarlosUnchained closed 8 months ago

CarlosUnchained commented 9 months ago

Hi!

Finally got WVR eurorack shield and loving it so far. I have a request that benefits any playback workflow on WVR and that's toggle sample. This means that a midi note (on/off) starts the sample, and the same note (on/off) stops it. On the eurorack shield you can only play long samples by holding a button or having a gate, which is not as convenient as pressing once to play and again to stop.

This would be also useful if you have a midi pad controller, in which a note would start a sample and another press to stop it instead of having to hold it with a finger.

I suggest adding it on note off settings, since mode would be still relevant.

PS: The google group is a spam mess. Cheers!

marchingband commented 9 months ago

Hello, Thank you for the tip on the google group! This feature is available, it is retrigger: note-off note-off: ignore https://github.com/marchingband/wvr#understanding-retrigger-mode

Feel free to reopen if you have more questions!

CarlosUnchained commented 9 months ago

Oh thanks @marchingband ! There's one situation that doesn't work, and that's with loop or adr loop selected. In that situation note off stops the playback even if it's set to ignore.

Captura de pantalla 2023-12-10 a las 16 10 10
marchingband commented 9 months ago

oh man, ok, yes this is bug! I am planning to get a release out around new years, I have some time over the holiday. Thank you!

marchingband commented 8 months ago

fixed in 3.9.0