marchjlim / pe

0 stars 0 forks source link

Overzealous input validation #29

Open marchjlim opened 1 week ago

marchjlim commented 1 week ago

Email and name do not support accented characters in strings such as "José" or "José @gmail.com"

Based on RFC 6530, such emails should be supported as the global standard.

Such names not being supported is not inclusive towards the user group of people with such names who work in restaurants.

nus-se-bot commented 5 days ago

Team's Response

Thank you for pointing this out. We acknowledge that the current input validation does not support accented characters in names and emails, such as "José" or "José@gmail.com." While we recognize that RFC 6530 allows such emails as a global standard and that supporting accented characters would improve inclusivity, this limitation is a result of our current validation implementation.

At this time, the app is designed to prioritize simplicity and robustness in input handling. Extending support for accented characters would require significant changes to our input validation logic and is currently outside the scope of this project. However, we acknowledge that this could impact a subset of users and recognize the importance of inclusivity for names and emails in a globalized setting.

We appreciate your feedback and will consider supporting accented characters in future iterations of the app to better serve diverse user groups.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]