marchjlim / pe

0 stars 0 forks source link

Find command does not properly search based on names #8

Open marchjlim opened 1 week ago

marchjlim commented 1 week ago

image.png

The above is the result of trying to search for a person in the contact list based on name, and the hyphen is used here.

Since a contact name can have the hyphen, there should be support for searching based on names with hyphens in them in the find command.

Users can no longer search based on hyphens and it hinders the user experience.

nus-se-script commented 1 week ago

Team's Response

Duplicate of #2689 as the find command does not support special characters

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to use s/o as a keyword when finding a customer

While NomNomNotifier allows for a user to add customer with the name "s/o", after adding such a customer, I am unable to find that same customer with the "s/o" as a keyword, using the following command find "s/o" throws the following error to me

This makes it such that despite including the feature to make customers with "s/o" as part of their name, they left out the important feature to allow find to exert the same behavior as the add feature, hence it is a functionality bug.

image.png


[original: nus-cs2103-AY2425S1/pe-interim#3667] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The team accepts this issue as the find command does not recognise special characters.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** This is not a feature flaw, as the find command is supposed to adequately support the use case: "Finding a person named Jose- in the contact book". The intended feature (as described in the UG) is that users can find persons by their name. The implementation of the command does not adequately support this. This function should have been properly implemented, given that the add command has the feature to add persons with the hyphen in their name, yet the find command does not support this. It doesn't make sense that the features for the find command (name-wise) and add command (name-wise) are not in sync. An attached screenshot of the UG is given below: ![image.png](https://raw.githubusercontent.com/marchjlim/pe/main/files/d5bf3eb9-4888-45ba-8b61-fe59f83ec43b.png)