search

marcin-osowski / igc_lib

A simple library to parse IGC logs and extract thermals.
MIT License
50 stars 20 forks source link

Glide alt_change() is wrong #53

Closed llauner closed 4 years ago

llauner commented 4 years ago

In the Glide class we have: def alt_change(self): """Return the overall altitude change in the glide, meters.""" return self.enter_fix.alt - self.exit_fix.alt

It should be return self.exit_fix.alt - self.enter_fix.alt So that it does reflect climbs (positive value) and sinks (negative values)

marcin-osowski commented 4 years ago

Thanks, fairly embarassing :0

Fixed in 14d683768e5f970abf612e978ed8ad98013d6d0d

llauner commented 4 years ago

No problem ! :)

You're library is great and I've forked it to create a thermal heatmap. The result is here: https://llauner.github.io/heatmapWeb/

I would now like to enrich it to be able to detect "sink glides" in the form of a list of "lines" a line being 2 points. I'd like to detect the lines were the sink rate is <= x m/s (let's say -1.5 m/s)

Now...my math years are long gone, and I'm not sure how to do this ? Just looking at the start and end of a glide doesn't work of course.

Would you know how to do this ? I guess that wouild involve some matrix calculation of some sort...

Regards Ludovic

Ludovic Launer ludovic@launer.fr

On Wed, 29 Jan 2020 at 22:41, Marcin Osowski notifications@github.com wrote:

Thanks, fairly embarassing :0

Fixed in 14d6837 https://github.com/xiadz/igc_lib/commit/14d683768e5f970abf612e978ed8ad98013d6d0d

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xiadz/igc_lib/issues/53?email_source=notifications&email_token=AH2QQDIVE6WQAACW6TN3W2TRAHZZTA5CNFSM4KNBL7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKI27TQ#issuecomment-579973070, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2QQDKDQA4B6SLFL3NYIHLRAHZZTANCNFSM4KNBL7GA .