search

marcinadd / projecty-web

Project management software based on spring
GNU General Public License v3.0
74 stars 75 forks source link

Remove getTeamManagersCount() method in TeamRoleService #11

Closed marcinadd closed 5 years ago

marcinadd commented 5 years ago

Use countBy in TeamRoleRepository instead

zunairaShafiq commented 5 years ago

Hi I wanted to solve this would you please tell me the process i am the first time contributor.

marcinadd commented 5 years ago

TeamRoleService has method getTeamRolesWhereManager() which can be replaced by countBy… method in TeamRoleRepository, same as in ProjectRoleRepository for example.

zunairaShafiq commented 5 years ago

so you want me to remove private int getTeamManagersCount(Team team) method from TeamRoleService and create a method int countByTeamAndName(Team team, TeamRoles name); in TeamRoleRepository class? is that right if yes than please guide me how create branch and than pull request.

Thanks in advance

marcinadd commented 5 years ago

Yes. You're right. Read something about contributing.

zunairaShafiq commented 5 years ago

I have created a pull request for this issue. please review thanks