search

marcinadd / projecty-web

Project management software based on spring
GNU General Public License v3.0
74 stars 74 forks source link

Move logic to service classes #42

Closed didaRatsimba closed 4 years ago

didaRatsimba commented 4 years ago

As I started to work on #12 I saw that you have logic part of the code in controller instead of service classes, I can work on the branch I created to make you avoid cyclic dependencies and have a well designed app. If you don't think it's necessary, I can create a new branch with "Domain" but it will be difficult to maintain the code as many entities are starting to have mutual association.

marcinadd commented 4 years ago

It will be helpful but don't forget to change fix classes since they have unsatisfied dependencies.

didaRatsimba commented 4 years ago

I didn't see the mail, I'll correct test classes then

marcinadd commented 4 years ago

48