search

marcinadd / projecty-web

Project management software based on spring
GNU General Public License v3.0
76 stars 76 forks source link

Api mappings #50

Closed didaRatsimba closed 5 years ago

didaRatsimba commented 5 years ago

wanted to work on #49 but tests failed so I corrected test first

marcinadd commented 5 years ago

Oh thanks for your effort but I have probably finished this already. I used Gson for testing. @fokion Can you take a look? What do you think about mappings? Is better my approach or @didaRatsimba 's to URLs?

fokion commented 5 years ago

@marcinadd what do you want me to have a look? do you have a branch that you can share ?

marcinadd commented 5 years ago

@fokion I didn't know that somebody had started working on mappings so I started work myself. Now there are a lot of merge conflicts. I want you to look at my and @didaRatsimba api-mappings branches and tell which looks better for you.

marcinadd commented 5 years ago

Thanks for your contribution. I was hard to decide but listening to some opinions I've decided to use my simpler mappings.

didaRatsimba commented 5 years ago

Okay, I will ask before taking a task then.