search

marcinbor85 / SmartButton

Asynchronous SmartButton library for handling various button events
MIT License
15 stars 9 forks source link

RP2040 compatibility #1

Open ChrisVeigl opened 6 months ago

ChrisVeigl commented 6 months ago

Hi, I could not compile the SmartButton library for the Arduino Nano 2040 Connect (RaspberryPi Pico) using the RP2040 core by Early Philhower (https://github.com/earlephilhower/arduino-pico)

The problem are different types for the declaration of the digitalRead() function, here: https://github.com/marcinbor85/SmartButton/blob/e874e86d82c4b879060f537a01d0ad1e7b8835f3/src/SmartButtonDefs.h#L16

I fixed it in my fork: https://github.com/ChrisVeigl/SmartButton/blob/f0a2f669fc505bdc7b7235c59ff3aa2bf31d421c/src/SmartButtonDefs.h#L16

but this probably needs a more generic solution.

thanks for this great library!

Taschi120 commented 4 months ago

Same issue happens on the Arduino Nano ESP32.