[Feature Request]: need additional value for clone role to eventstore_cluster_member_is_master metric

marcinbudny / eventstore_exporter

EventStoreDB (https://eventstore.com/eventstoredb/) metrics Prometheus exporter.

MIT License

52 stars 10 forks source link

[Feature Request]: need additional value for clone role to eventstore_cluster_member_is_master metric #4

Closed gokcesurenkok closed 5 years ago

gokcesurenkok commented 5 years ago

Hello , it would be nice to see the nodes in clone state , currently as far as i see , value mapping is as like following, 1 - master 0 - slave , for the clone nodes it would be nice to have something like this 1 - master 0 - slave 2 - clone

Thank you

marcinbudny commented 5 years ago

Hi and thank you for the suggestion. I need to check what is available in the API. The current metric specifies "is master" boolean flag, so adding another value to it makes little sense. A new metric may be more sensible, something like "is clone".

PR for this is welcome.

gokcesurenkok commented 5 years ago

hi , a new metric is also ok , but you are checking the node role via eventstore_cluster_member_is_master metric in your grafana dashboard, that is why i said so :)

marcinbudny commented 5 years ago

The node status metrics have been added in 0.5.0. Grafana dashboard is also updated.