marcingminski / sqlwatch

SQL Server Performance Monitor
https://docs.sqlwatch.io
Other
436 stars 171 forks source link

SQLWATCH 4.3: Is [dbo].[sqlwatch_config_snapshot_type].[collect] working? #449

Open kekcjkee opened 2 years ago

kekcjkee commented 2 years ago

Describe the bug I have set column "collect" to 0 for some snapshots. For example: Disk Utilisation Table, Disk Utilisation Database. But I can't find the part of the code where it is used. Job: SQLWATCH-LOGGER-DISK-UTILISATION anyway collects data.

I have VLDB which has size about 30TB. So this job takes a very long time. Sometimes it is reason for blocking user's query.

To Reproduce Steps to reproduce the behavior:

  1. UPDATE [dbo].[sqlwatch_config_snapshot_type] SET collect = 0 WHERE [snapshot_type_id] in (2, 22)

  2. Look on job SQLWATCH-LOGGER-DISK-UTILISATION

Expected behavior I want to understand how is working [dbo].[sqlwatch_config_snapshot_type].[collect].

Screenshots image

Windows Server (please complete the following information):

SQL Server (please complete the following information):

SQL Server Management Studio (SSMS -> about -> copy info): SQL Server Management Studio 15.0.18358.0 SQL Server Management Objects (SMO) 16.100.44091.28 Microsoft Analysis Services Client Tools 15.0.19260.0 Microsoft Data Access Components (MDAC) 10.0.14393.0 Microsoft MSXML 3.0 6.0 Microsoft .NET Framework 4.0.30319.42000 Operating System 10.0.14393

SQLWATCH version (from DACPAC or from sysinstances)

marcingminski commented 2 years ago

This should work if it doesn't it's probably a bug. I'd probably recommend disabling the job in the first place. This flag/switch was designed for job-less operations i.e. broker or a collector app.