marcingminski / sqlwatch

SQL Server Performance Monitor
https://docs.sqlwatch.io
Other
424 stars 168 forks source link

dbatools install broken on some Standard Edition #482

Open bflippin opened 12 months ago

bflippin commented 12 months ago

Did you check DOCS to make sure there is no workaround? https://sqlwatch.io/docs/

Describe the bug A clear and concise description of what the bug is.

Running install through DBAtools on SQL Server 2014 Standard fails due to compression being on by default.

To Reproduce Steps to reproduce the behavior: Run the dbatools installer on any edition of SQL Server that doesn’t support compression.

Expected behavior A clear and concise description of what you expected to happen.

I would like either an edition check or a command line switch to turn on/off compression instead of the install failing.

Screenshots If applicable, add screenshots to help explain your problem.

Windows Server (please complete the following information):

SQL Server (please complete the following information):

**SQL Server Management Studio (SSMS -> about -> copy info): Did not use SSMS here.

SQLWATCH version (from DACPAC or from sysinstances)

Additional context

If this should go to the dbatools team instead I will submit it over there. I was able to remove the compression defaults and deploy without issue from Visual Studio.

marcingminski commented 12 months ago

Yeah that was changed in 4.8 on the basis that it will make life easier for the majority running 2016 onwards. Apologies it didn’t work for you. Being able to pass parameters during install would be ideal, but impossible with the current implementation (compression is define in the project as part of Schema).

I guess documentation would need updating.

Anyway, happy to help you get this installed on 2014 if you didn’t manage yet . Or, if you are familiar with database projects, you’d need to remove the compression from the table definition (quite a lot of find and replace), rebuild the project and deploy.