search

marcinjahn / gnome-peek-top-bar-on-fullscreen-extension

Gnome Extension that triggers top panel to show up on full screen apps when cursor hovers the top edge of the screen
MIT License
22 stars 0 forks source link

Wrong name of .gschema.xml #3

Closed doppelhelix closed 1 year ago

doppelhelix commented 1 year ago

Right now the filename is org.gnome.shell.extensions.quicksettings-audio-devices-renamer.gschema.xml Wouldn't it be better to rename it to org.gnome.shell.extensions.peek-top-bar-on-fullscreen.gschema.xml?

marcinjahn commented 1 year ago

Hi @doppelhelix, thanks for spotting that. Actually, this file can just be completely removed, since it is needed only for defining configuration options. This extension is not configurable in any way at the moment, so it can just go. This file, together with a bunch of others, has been copied from Audio Devices Renamer, to skip the tedious process of creating everything from scratch.

If you want, feel free to submit a PR that removes that file. Otherwise, I'll do it sometime later.

doppelhelix commented 1 year ago

Since I do not know anything about npm and the underlying build-process, I do not dare to make a PR. I stumbled upon this only because my PKGBUILD script is parsing the metadata.json for the gschema.xml

marcinjahn commented 1 year ago

@doppelhelix The only thing to do in the PR would be the removal of this file. No need to touch the package.json. The commands there are generic, and don't need to be changed. If there is no schema, it will just not compile it, and it's totally fine.

doppelhelix commented 1 year ago

ok

doppelhelix commented 1 year ago

I feared as much

> peek-top-bar-on-fullscreen@1.0.0 build
> glib-compile-schemas resources/schemas/ && npm run clean && rollup -c && npm run lint-dist

Error opening directory “resources/schemas/”: No such file or directory
marcinjahn commented 1 year ago

It should be fine now, empty directories will not be fetched, I added a keeper file there, and it should be alright

doppelhelix commented 1 year ago 
No schema files found: doing nothing.

Thanks a lot

marcinjahn commented 1 year ago

@doppelhelix, fyi, in the end I removed the schemas directory entirely since I got such request during extension review on extensions.gnome.org/.