marcinjakubowski / date-menu-formatter

Date Menu Formatter GNOME Shell extension
GNU General Public License v2.0
34 stars 15 forks source link

Update for GNOME 45 #25

Closed andyholmes closed 7 months ago

andyholmes commented 9 months ago
andyholmes commented 9 months ago

I tried to touch as little as possible, leaving anything unrelated to the porting process as-is. I also left the version bump to you, but let me know if I missed anything :slightly_smiling_face:

ciscorucinski commented 9 months ago

I downloaded the code for the PR and added it to my system (and renamed the folder), but I got an error message.

@andyholmes were you able to get the PR working on your machine? Given that Gnome 45 will not be added anytime in the foreseeable future (https://github.com/marcinjakubowski/date-menu-formatter/issues/26), it might be advisable to create your own fork and upload it so others on Gnome 45 can use this extension

andyholmes commented 9 months ago

Yep, it worked for me. Renaming the folder might have caused problems, since the folder name must match the UUID in metadata.json. Other than that, an error message would give more clues :slightly_smiling_face:

ciscorucinski commented 9 months ago

Yes, I had to rename it to the UUID .local/share/gnome-shell/extensions/date-menu-formatter@marcinjakubowski.github.com

The settings of extension date-menu-formatter@marcinjakubowski.github.com had an error:

SyntaxError: import declarations may only appear at top level of a module

Stack trace:

_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:204:33
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:8
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17
andyholmes commented 9 months ago

Are you sure it's the version here installed? It works for me:

Screencast from 2023-09-30 16-09-36.webm

Here's a ZIP:

date-menu-formatter@marcinjakubowski.github.com.shell-extension.zip

ciscorucinski commented 9 months ago

I was getting the same error message after installing using the above zip file. I was just copy-pasting-renaming directories.

I then tried to use gnome-extensions create -i and just copy-pasted the files from the zip into the newly created extension directory, and followed some gnome extension creation documentation online to enable and restart. My Extension Application showed there was a new version available and to restart my system. After restarting the system, the extension is working now as expected.

Screenshot from 2023-10-01 18-13-51

gamersi commented 9 months ago

it works for me! thanks!

queenbiscuit311 commented 8 months ago

I couldn't get the gnome-extensions create -i solution to work at first but it would appear that contrary to guides online restarting the shell does not work but restarting the system does. Working great now.

ciscorucinski commented 8 months ago

One thing I noticed afterwards is that my system wasn't using Gnome 45, so I was so confused as to why the code was working for an older Gnome version. I was unable to download any older versions before.

But, I guess, when my extensions app said there was a new version, it downloaded an older version as none of the code uses the new import declarations anymore. But I'm confused as to why I wasn't able to download an older version before.

lateparty commented 7 months ago

Downloaded the zip from https://github.com/marcinjakubowski/date-menu-formatter/pull/25#issuecomment-1741879140 and confirmed as working for me on Gnome 45.1 and Arch synced to the latest repos.

ciro-mota commented 7 months ago

Working normally for me for weeks. Arch Linux - GNOME 45.

queenbiscuit311 commented 7 months ago

Working normally for me for weeks. Arch Linux - GNOME 45.

Same here. Had the clock freeze once but that's about it, working perfectly otherwise.