marcinjakubowski / date-menu-formatter

Date Menu Formatter GNOME Shell extension
GNU General Public License v2.0
34 stars 15 forks source link

[REWORK][FEAUTURES] Migrate to Typescript for better maintenability and some other improvment #36

Open bomdia opened 3 months ago

bomdia commented 3 months ago

@marcinjakubowski, @andyholmes, @pengshao, @toolstack in my view we should migrate the codebase to typescript https://gjs.guide/extensions/development/typescript.html the pros would range from better code readability and code hinting and linting from the ability to automatize the building process and the ability of importing npm library without having to manually download and copy it with better version management (ex luxon library)

i can start the migration to ts but before i want your opinion

on another aspect we should migrate prefs to libadwaita like a lot of the extension out here (better graphics and support)

and maybe implementing some automated test

i don't know much on how to automatize the workflow

other than that i think the default format string we currently use is horrible and we should change it.

my current format is: πŸ—“οΈ EEE D πŸ•— TT 🌐 ZZZZ Z πŸ—“οΈ sab 30/3/2024 πŸ•— 19:10:39 🌐 CET +1

and i very would like to have the ability to use this extension on the lockscreen and loginscreen but from what i've seen the lockscreen should be easy, but the loginscreen is dependant on another user (gdm) and so we should somehow overwrite the gdm dconf setting from the current user (pkexec ?)

andyholmes commented 3 months ago

Thanks for the ping, but I'm not actually a maintainer of this extension :)

bomdia commented 3 months ago

ahh yes and it's time to add an icon to this extension 😜

bomdia commented 3 months ago

@andyholmes well i've pinged all github contributor, anyhow what do you think about it

andyholmes commented 3 months ago

I'm sorry, but I really don't have time to take on another project right now.

If you want my opinion, the best way to engage a maintainer (i.e. Marcin) is to open a proof-of-concept PR with something tangible they can review.

bomdia commented 3 months ago

it's fine that you don't have time, i think that before a p.o.f. we should discuss what to do, i just wanted your opinion on the points that i've raised and if you have some other point, i'm not asking anyone to implement it, its just to define a roadmap as the thing i've proposed aren't marginal thing, if other user of the extension want to raise some other point we can discuss it

toolstack commented 3 months ago

I'm not a maintainer either, but here are my two cents worth:

In general, much like the other comment, if you want to do some of this work it's better to submit some code. Start small (like adding the icon) and see how your PR's are received. Then you can start working on some of the bigger items.