search

marcinlos / iga-ads

Isogeometric Finite Element Method framework
MIT License
14 stars 8 forks source link

Fix memory management of `basis_data` #48

Closed marcinlos closed 3 years ago

marcinlos commented 3 years ago

Adding destructor and copy constructor for ads::basis_data prevents memory leaks and crashes when copying. Ultimately, manual memory management should be replaced by a proper multidimensional array.

Closes #13

codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (04567c7) into develop (ffb64d3) will increase coverage by 5.44%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #48      +/-   ##
===========================================
+ Coverage    23.64%   29.08%   +5.44%     
===========================================
  Files           43       43              
  Lines         1108     1131      +23     
===========================================
+ Hits           262      329      +67     
+ Misses         846      802      -44
Impacted Files Coverage Δ
include/ads/basis_data.hpp 12.50% <ø> (+12.50%) :arrow_up:
src/ads/basis_data.cpp 100.00% <100.00%> (+100.00%) :arrow_up:
include/ads/bspline/bspline.hpp 55.55% <0.00%> (+2.77%) :arrow_up:
src/ads/bspline/bspline.cpp 82.25% <0.00%> (+11.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffb64d3...04567c7. Read the comment docs.