Rails 6 support - Githubissues

marcinruszkiewicz / where_chain

WhereChain - don't write Post.where('comments > ?', 5), write Post.where.gt(comments: 5) instead!

MIT License

44 stars 4 forks source link

Rails 6 support #4

Closed marcinruszkiewicz closed 4 years ago

marcinruszkiewicz commented 4 years ago

I haven't yet looked if there are a lot of changes needed from the Rails 5 version, I'm expecting some, but not that many it will be unmanageable.

The code is still in the same place as in 5 and on a first glance looks pretty much the same, though it should still be obviously tested.

What needs to be done here:

[ ] add 6.0 to Appraisals file
[ ] make sure the dummy app that's used for rspec still works in 6.0 or make it work
[ ] add 6.0 to the CI config
[ ] finally, pass the tests on 6.0 both locally and on CI

dodo121 commented 4 years ago

I'm having a look at it.