Closed pablobm closed 8 years ago
The tests are failing because the node version used on travis is too old. I'll change it soon. Everything worked fine here. Can you squash your commits?
Sure thing. However, Github now has a feature for that: press the dropdown on the merge button and you'll see the option. Would you rather do that? It's ok if not, I can do it.
Wow, amazing I didn't know about that. Thank you for the tip and the PR @pablobm !
After two false takes, here's a decent (hopefully?) PR for generating JSON-API-ready applications.
The details:
/api
namespace, as it is too specific. Different apps put their APIs in different placesPATCH
instead ofPUT
, as is the default in Ember Data 2There's an annoying workaround I had to introduce to get
tests/unit/blueprints/scaffold-test.js
to pass. Turns out thatBlueprint#install
doesn't know of blueprints of external packages, or at least doesn't in that isolated test. Eg: it doesn't know there's a blueprint formodel
(from Ember Data) or one formirage-model
(from Mirage). Therefore I had to add an command-line argument--skip-model
to skip these blueprints in the test. This is not documented and not expected to be used by end users.