marcioj / ember-cli-scaffold

Scaffolds models, routes and templates a la rails
https://github.com/marcioj/ember-cli-scaffold
43 stars 9 forks source link

JSON-API - Take 3 #35

Closed pablobm closed 8 years ago

pablobm commented 8 years ago

After two false takes, here's a decent (hopefully?) PR for generating JSON-API-ready applications.

The details:

There's an annoying workaround I had to introduce to get tests/unit/blueprints/scaffold-test.js to pass. Turns out that Blueprint#install doesn't know of blueprints of external packages, or at least doesn't in that isolated test. Eg: it doesn't know there's a blueprint for model (from Ember Data) or one for mirage-model (from Mirage). Therefore I had to add an command-line argument --skip-model to skip these blueprints in the test. This is not documented and not expected to be used by end users.

marcioj commented 8 years ago

The tests are failing because the node version used on travis is too old. I'll change it soon. Everything worked fine here. Can you squash your commits?

pablobm commented 8 years ago

Sure thing. However, Github now has a feature for that: press the dropdown on the merge button and you'll see the option. Would you rather do that? It's ok if not, I can do it.

marcioj commented 8 years ago

Wow, amazing I didn't know about that. Thank you for the tip and the PR @pablobm !