free-text propose - Githubissues

marcioos / bg-club-bot

Telegram bot that fetches info about a boardgame and sends a nice looking message to propose it to your group's next game night

1 stars 0 forks source link

free-text propose #1

Open marcioos opened 7 years ago

marcioos commented 7 years ago

The free-text propose endpoint should be hooked to the /propose name of the game bot command. It will search bgg using the bgg-axios search function and do either of the following actions based on the search output:

If a single result is returned: Post a proposal message to the group. This message should be built the same way bgg-id propose does.
If multiple results are found: Ask the sender which game among the first 3 results is the desired one, with an option to cancel. (no idea on how to do this yet)
If no results are found: Tell the sender that no game was found
If something went wrong while processing the request: Send and error message to the sender.

ticolucci commented 7 years ago

Since we need to do parsing by hand in the telegram update (text message), I suggest to separate the commands in /search <name> and /propose <bgg_id>.

WDYT?

marcioos commented 7 years ago

I think it would be nice if the user could just /propose <whatever> and the bot figures out what to do (prompt the user with possible matches or post the proposal message directly). I think we can achieve that with a single propose endpoint that routes to the proper logic based on the parameter type: if it is an integer, treat it is as a bgg_id, otherwise as a game name.

WDYT? Too naive?

lonefreak commented 7 years ago

I like the approach suggested originally, being only one entrypoint that acts accordingly. Maybe it is a bit too naive, but I have the impression that the usage will be simpler this way.

ticolucci commented 7 years ago

Ok. =)

Let's go for it!! o/

On Mon, May 22, 2017 at 10:30 PM Fabricio Leotti notifications@github.com wrote:

I like the approach suggested originally, being only one entrypoint that acts accordingly. Maybe it is a bit too naive, but I have the impression that the usage will be simpler this way.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/marcioos/bg-club-bot/issues/1#issuecomment-303211555, or mute the thread https://github.com/notifications/unsubscribe-auth/AABaZfkDwjJMZe-cbmQWhjKrHHoE_4BKks5r8fBQgaJpZM4Nie8Q .

--

Thiago Rodrigues Colucci Mobile: +46 076 526 0020