search

marciot / esp32-dali-clock

An NTSC/PAL version of the 80s Dali Clock for the ESP32
GNU General Public License v3.0
117 stars 10 forks source link

LInes at the bottom of the screen are duplicated in PAL mode #2

Closed richms closed 2 years ago

richms commented 2 years ago

https://youtu.be/tKJLKOonMMs

Seems that there are a few lines at the bottom that are duplicated rather than the grid extending to the bottom of the screen,

I have changed the lines in the main .ino file to have

define SUPPORT_NTSC 0

define SUPPORT_PAL 1

and furthur down

CompositeColorOutput composite(CompositeColorOutput::PAL);

is there anything else to get this working right?

marciot commented 2 years ago

@richms: This was actually a bug in the original PAL video out code which I should have corrected now.

If after testing the fix you find it works, please close this ticket. Thank you for reporting!

richms commented 2 years ago

Yup, bottom of the screen is now black.