search

marcisme / sketch-preview

Sketch plugin to preview mockups in Skala Preview
MIT License
611 stars 37 forks source link

Support 3.3+? #21

Closed jcwenzel closed 9 years ago

jcwenzel commented 9 years ago

First off this is an amazing tool. Thank you for creating it. I was wondering if you have any plans to support Sketch 3.3? Thanks!

marcisme commented 9 years ago

Thanks. I'm glad you've found it useful.

I do plan to update to the new bundle format eventually, but for now the plugin is still working for me in 3.3.2. Is it not working for you? If not, what versions of Sketch, Skala Preview and the plugin are you using?

jcwenzel commented 9 years ago

Awesome. I guess I might be having an issue with the WIFI connection then... but just incase it is the plugin I'm using:

Skala Preview 1.6.0 Sketch 3.3.2 For the plugin I use Sketch Toolbox so it should be up-to-date

On Tue, May 12, 2015 at 9:48 AM, Marc Schwieterman <notifications@github.com

wrote:

Thanks. I'm glad you've found it useful.

I do plan to update to the new bundle format eventually, but for now the plugin is still working for me in 3.3.2. Is it not working for you? If not, what versions of Sketch, Skala Preview and the plugin are you using?

Reply to this email directly or view it on GitHub https://github.com/marcisme/sketch-preview/issues/21#issuecomment-101345502 .

marcisme commented 9 years ago

That should all work then. Is the file not opening in Skala Preview at all, or is it not showing up on your device? It might also be helpful to check for log messages in Console.app.

ederdesign commented 9 years ago

Just wondering @marcisme. Did you manage to fix the problem? I'm actually having the same problem. I select the page, but nothing happens. I took a look at the console.app, but I have no idea about what's happening. Thanks.

marcisme commented 9 years ago

@ederdesign Do you have an artboard selected? Also I've noticed that Sketch seems to need to be restarted after installation now before the keyboard shortcut works.

Nordicdesign commented 9 years ago

I can't use it with 3.3.2, it doesn't load the preview on my machine, thus the phone doesn't know Skala Preview is running. I get the following message: screen shot 2015-05-30 at 16 55 02

Also got a couple of warnings on the console, in case it's useful. No idea what all that means :)

30/05/2015 16:53:50.508 Sketch[7314]: Deprecation Warning in : /Users/alexlillo/Library/Application Support/com.bohemiancoding.sketch3/Plugins/SketchPreview/lib/common.js, line 21 «Plugin Developer»

30/05/2015 16:53:50.509 Sketch[7314]: Deprecation Warning in : /Users/alexlillo/Library/Application Support/com.bohemiancoding.sketch3/Plugins/SketchPreview/Preview.sketchplugin, line 23 «Plugin Developer»

30/05/2015 16:53:50.509 Sketch[7314]: Warning: #import syntax for CocoaScript is deprecated. Please update your script to use @import instead. «Plugin Developer»

marcisme commented 9 years ago

@Nordicdesign Thanks for reporting this. Can you set the DEBUG variable to true in SketchPreview/lib/common.js, and post the output here? I still can't reproduce any problems on my machine, and the debug output will give me some more information to work with.

marcisme commented 9 years ago

@Nordicdesign Did you happen to rename Skala Preview to something else?

marcisme commented 9 years ago

I updated the plugin to v0.8.0 today, and it is now using the new bundle format. I also moved the debug logging into the setup plugin, so turning that on no longer requires editing a file. Give the new version a try, and let me know if it's still not working for you.

Nordicdesign commented 9 years ago

Still nothing I'm afraid.

I've deleted the plugin and installed it again, just in case. The funny thing is that the setup screen works. I tried with a brand new file, and still nothing. Also disabled the firewall just in case.

This is what I got on the console app, in case it helps. (edited to paste text)

31/05/2015 20:04:28.800 Preview (Sketch Plugin)[9258]: DEBUG: config loaded from: file:///Users/myusername/Library/Caches/com.marcisme.sketch-preview/config.plist 31/05/2015 20:04:28.800 Preview (Sketch Plugin)[9258]: DEBUG: config: { debug = 1; previewSizeIndex = 0; scalingStrategyId = 2; } 31/05/2015 20:04:28.801 Preview (Sketch Plugin)[9258]: DEBUG: Searching for named preview slice: Preview 31/05/2015 20:04:28.802 Preview (Sketch Plugin)[9258]: DEBUG: No named preview slice found 31/05/2015 20:04:28.802 Preview (Sketch Plugin)[9258]: DEBUG: Searching for selected Artboard 31/05/2015 20:04:28.803 Preview (Sketch Plugin)[9258]: DEBUG: Found selected Artboard: iPhone 6 Plus 31/05/2015 20:04:28.804 Preview (Sketch Plugin)[9258]: DEBUG: writing preview image to: /Users/myusername/Library/Caches/com.marcisme.sketch-preview/preview.png 31/05/2015 20:04:28.805 Preview (Sketch Plugin)[9258]: DEBUG: searching for scalingStrategyId: 2 31/05/2015 20:04:28.805 Preview (Sketch Plugin)[9258]: DEBUG: found strategy: Scale for iPhone (320x568@2x, 375x667@2x, 414x736@3x) 31/05/2015 20:04:28.806 Preview (Sketch Plugin)[9258]: DEBUG: preview scale factor: 3

Thanks, Alex

On Sun, 31 May 2015 at 02:43 Marc Schwieterman notifications@github.com wrote:

I updated the plugin to v0.8.0 today, and it is now using the new bundle format. I also moved the debug logging into the setup plugin, so turning that on no longer requires editing a file. Give the new version a try, and let me know if it's still not working for you.

— Reply to this email directly or view it on GitHub https://github.com/marcisme/sketch-preview/issues/21#issuecomment-107106632 .

marcisme commented 9 years ago

Does Skala Preview work on its own? For example, if you drag and drop an image onto its dock icon, does that image show up in the main application window?

Are you using the direct download version of Sketch? (I'd guess so based on the preview image path.) I'll see if I can reproduce with the demo version.

Nordicdesign commented 9 years ago

Ok you can close it now. This SO terribly embarrassing that I'd prefer not to say why it wasn't working but... here you go:

I didn't have Skala Preview installed in this machine.

Stupid, I now. I did a fresh install some days ago, and what I remembered was the sketch plugin, not the app itself. So I installed the plugin and thought that it was enough, and went to install all the other software. Sketch said 'make sure Skala Preview is installed' and I thought it was... the plugin of course, not the app. ARRGGG, idiot.

Anyway, really sorry about this, and thanks for the help :S You can have a laugh on me. :)

marcisme commented 9 years ago

Believe me, stuff like that happens to all of us. ;) I'm glad it's working for you now.