search

marcisme / sketch-preview

Sketch plugin to preview mockups in Skala Preview
MIT License
610 stars 37 forks source link

incompatible with Sketch v41 (beta) #39

Closed RaphyRaph closed 7 years ago

marcisme commented 7 years ago

Thanks for reporting this issue.

Does this branch for the v41 beta work for you?

RaphyRaph commented 7 years ago

preview works! auto-preview does not, however.

marcisme commented 7 years ago

So far in my testing auto-preview is working with this change.

Can you turn on the debug logging option and post the output from Console.app here?

evandiamond commented 7 years ago

Hi, when do we think a fix will be pushed? Thank you for all your help on this great plugin!

marcisme commented 7 years ago

@evandiamond I released a new version over the weekend that "works on my machine".

I'll keep testing as I think of new things to try, but I need to be able to reproduce the failure before I can fix it, and it's unfortunately (ha) working for me.

evandiamond commented 7 years ago

@marcisme

Can you give me some details on how I would do 'Console.app'.

I installed the new version and cannot get it to run on any artboard in version 41

marcisme commented 7 years ago

You can run it from spotlight (⌘+space) by typing "console" or directly from Applications -> Utilities. There's a post on the Sketch site that shows how to create a filter for just the log messages from Sketch, although you don't necessarily have to do that.

Usually when a plugin fail, Sketch will log some kind of error message that should help figure out where it's failing. The debug logging option will add some more detail to further help figure out where in the export process things are going wrong.

Thanks for your help figuring this out.

evandiamond commented 7 years ago

​Does this help?

«Plugin Output» TypeError: MSExportRequest.requestWithRect_scale is not a function. (In 'MSExportRequest.requestWithRect_scale(rect,2)', 'MSExportRequest.requestWithRect_scale' is undefined) line: 10 sourceURL: /Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript column: 62 stack: onRun@/Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript:10:62 «Plugin Output» TypeError: MSExportRequest.requestWithRect_scale is not a function. (In 'MSExportRequest.requestWithRect_scale(rect,2)', 'MSExportRequest.requestWithRect_scale' is undefined) line: 10 sourceURL: /Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript column: 62 stack: onRun@/Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript:10:62 «Plugin Output» TypeError: MSExportRequest.requestWithRect_scale is not a function. (In 'MSExportRequest.requestWithRect_scale(rect,2)', 'MSExportRequest.requestWithRect_scale' is undefined) line: 10 sourceURL: /Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript column: 62 stack: onRun@/Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript:10:62 «Plugin Output» TypeError: MSExportRequest.requestWithRect_scale is not a function. (In 'MSExportRequest.requestWithRect_scale(rect,2)', 'MSExportRequest.requestWithRect_scale' is undefined) line: 10 sourceURL: /Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript column: 62 stack: onRun@/Users/evan/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Preview in browser.sketchplugin/Contents/Sketch/script.cocoascript:10:62 «Plugin Output»​

On Wed, Nov 9, 2016 at 11:12 AM, Marc Schwieterman <notifications@github.com

wrote:

console

Evan

RaphyRaph commented 7 years ago

works fine for me now on v41. Thanks! feel free to close.

marcisme commented 7 years ago

@RaphyRaph Awesome! Thanks for the update.

@evandiamond That is helpful. The error in that message looks like it's still using the old version for some reason. I'd try restarting sketch. If that doesn't work, you can delete the plugin from Plugins -> Manage Plugins... and reinstall.

marcisme commented 7 years ago

This should work now. Let me know that's not the case, and we can investigate further.