search

marcisme / sketch-preview

Sketch plugin to preview mockups in Skala Preview
MIT License
611 stars 37 forks source link

Not working in Sketch 3 #7

Closed Grawl closed 10 years ago

Grawl commented 10 years ago

I've made these steps:

robbschiller commented 10 years ago

+1

Looking for some way to get an error report.

jelias commented 10 years ago

Guys give Marc a break. Sketch 3 was released today, don't expect the plugin to just 'work' the first day of a new release. Especially a new major build.

Grawl commented 10 years ago

@jelias I checked a lot of plugins today and all of them works.

robbschiller commented 10 years ago

@jelias agree! Not expecting it to work. Bugs should be documented so others can work on them and submit a PR.

jelias commented 10 years ago

@Grawl I bet a few plugin devs were working with the beta version so that their plugin would work with v. 3. But there are a lot of changes with version 3, and probably a bunch of changes to the API. I haven't looked at the documentation yet, I'm still in school. Also the last commit to this repo was like two months ago, so Marc probably wasn't dev-ing in beta. Just saying don't expect something from v. 2 to work with v. 3. My plugin probably doesn't work...

@robbschiller thanks for backing me up!

davidklaw commented 10 years ago

It worked for me temporarily this morning but now can't seem to find my Mac. Just went and restarted my Android phone and it seems to be working again.

marcisme commented 10 years ago

Sorry to not respond sooner. I'm on a trip in India until next Tuesday, so I haven't been online much. I plan to upgrade the plugin once I'm back, so I should have something next week.

Grawl commented 10 years ago

@marcisme cool! Wish you a good journey.

Grawl commented 10 years ago

As a workaround I just move selected artboard thumbnail onto Skala Preview icon in Dock: https://vimeo.com/92308730

TomasLinhart commented 10 years ago

I have updated the plugin for Sketch 3. You can get it here https://github.com/TomasLinhart/sketch-preview

I have also sent a pull request so if marcisme accepts it, it wil be also available in this repository.

marcisme commented 10 years ago

I've pushed up a new version of the plugin that should work in both Sketch 2 and 3. There's also some debug logging you can turn on now. I tested pretty throughly on my machine, but if any of you could take the time to try the latest version out, I'd appreciate it.

Grawl commented 10 years ago

Worked in both Sketch 2.4.3 (beta 5347) and Sketch 3.0.1 (stable 7597) for me.

marcisme commented 10 years ago

@Grawl Thanks for testing.