search

marcizhu / readme-chess

♟️ Play Multiplayer Chess in a README file!
https://github.com/marcizhu
MIT License
89 stars 14 forks source link

Reverse the board after each turn. #16

Closed Hitro147 closed 11 months ago

Hitro147 commented 11 months ago

Hi @marcizhu,

This PR addresses Issue #14, which involves reversing the chessboard after each turn to improve the experience for the users, as suggested by @AzeemIdrisi.

Changes:

  1. The chessboard now reverses after each turn, ensuring that the perspective is correct for the player whose turn it is.
  2. I’ve incorporated the suggestions from your comments, @marcizhu, to ensure the implementation aligns with the project's standards.

Testing:

  1. I have tested these changes locally and verified that the chessboard reversal functions as expected without any apparent issues.

As this is my first PR for this project, I am especially keen on receiving feedback regarding:

  1. The coding conventions and style of the project.
  2. The efficacy of the implemented solution.
  3. Any potential edge cases I might have missed.

Please let me know if there are any additional improvements or changes you would like me to make. I appreciate your guidance and support.

Thank you for the opportunity to contribute!

Hitro147 commented 11 months ago

Absolutely, @marcizhu!

Appreciate your suggestion - it sounds like a more streamlined approach. I have updated the code accordingly and pushed the changes.

Thanks for the guidance!

marcizhu commented 11 months ago

@Hitro147 your changes are now live and working as expected at marcizhu/marcizhu:

image