search

marcj / css-element-queries

CSS Element-Queries aka Container Queries. High-speed element dimension/media queries in valid css.
http://marcj.github.io/css-element-queries/
MIT License
4.27k stars 487 forks source link

Fixed bug that prevented detach from being called on instance #169

Closed privard closed 7 years ago

privard commented 7 years ago

Detach method on instance is checking for this.withTracking, when it should be checking for trackingActive as defined in the init function. this.withTracking is out of scope in the instance detach method.

marcj commented 7 years ago

Good catch, thanks!

privard commented 7 years ago

My pleasure. Do you have an ETA for the next release?

marcj commented 7 years ago

No, but if you help me to test some browser with the master version I can kick out a release tonight/asap :)

privard commented 7 years ago

I don't mind helping you out, although I don't have access to a lot of different browsers. Latest Chrome and latest Firefox on Mac; latest chrome on android. Do you have specific test cases I could do?

marcj commented 7 years ago

I have nothing special, I just open the website (https://github.com/marcj/css-element-queries/tree/gh-pages) with newest css-element-queries lib and then try the demos in each browsers. Ususally Firefox, Chrome, Safari, IE 7,8,9,10,11. But I currently don't have windows at hand :)

privard commented 7 years ago

Cool, I'll see what I can do. Would you be open to adding unit tests in the repo to check for basic functionalities too?

marcj commented 7 years ago

Definitely! :) Wanted to do it already, but time is big factor :(

privard commented 7 years ago

Finally found someone to help with the tests. https://github.com/marcj/css-element-queries/issues/173