marcj / css-element-queries

CSS Element-Queries aka Container Queries. High-speed element dimension/media queries in valid css.
http://marcj.github.io/css-element-queries/
MIT License
4.27k stars 487 forks source link

Maybe it's time for a new release #173

Closed hpvd closed 6 years ago

hpvd commented 7 years ago

Maybe it's time for a new release, just to bring fixes and optimizations to public...

2017-06-12_14h53_47

Michaelmcd729 commented 7 years ago

I tested the tip of the Master branch on IE8 and IE9, and found the following issues.

IE8:

IE9:

These tests were run on my Intel laptop running windows 10 through VirtualBox running windows 7. I also tested the following, which worked just fine.

On my Intel laptop running windows 10:

On VirtualBox:

On BrowserStack:

ie9-win7-multibox ie9-performance demo

privard commented 7 years ago

Thanks @Michaelmcd729! @marcj I can vouch for him. I helped him with the tests.

marcj commented 7 years ago

oh well, I guess we need to address these bugs first before we can release :(

privard commented 7 years ago

Or we can create a new major build that drops support for IE8 and IE9? What are the stats these days. Last I supported these browsers was at least 3 years ago.

marcj commented 7 years ago

Yeah we could basically do that, but to be honest IE6-IE9 is the browser that is the easiest to support when we'd not use the resize hack, but just the regular IE-Only "onresize" event (which is already element based). However, I guess most of the bugs stated above is related to some Demo code only. Should be easy to fix I guess.

hpvd commented 7 years ago

having a new major build which drops support of older IEs may be a good looking quickfix. Imho there are at least 4 points to be considered:

marcj commented 7 years ago

@hpvd Your 4 points are pro "remove IE support"?

hpvd commented 7 years ago

@marcj no. I'm not a fan of dropping support for older versions of browsers. But if one decide to do so (e.g. because it is simply too hard/not possible to support these older browsers), on should really

btw: USP means "unique selling point"

privard commented 7 years ago

To address your first point, are we sure that the problems identified by @Michaelmcd729 are actually regressions? Saw a couple of issues mentioning the resizing not working in various versions of IE in the previous builds.

marcj commented 6 years ago

Release 1.0.0 incoming. With this release we only support IE10 and up.