search

marcj / jquery-selectBox

A jQuery plugin for replacing <select> elements.
http://marcj.github.io/jquery-selectBox/
549 stars 212 forks source link

fix enable and disable when selectbox destroyed #177

Open bogdanRada opened 8 years ago

bogdanRada commented 8 years ago

This pull request is a continuation of this pull request https://github.com/marcj/jquery-selectBox/pull/150

Seems if the selectbox is disabled and then destroyed, if the selectbox is not enabled and you want to set options on the select and then enable it, seems the attribute "disabled" is not removed.

You can test this here: http://jsfiddle.net/xx97so9m/1/ ( using master branch from github) - This is a demo of the bug .

If needed i can make a demo with the fixed version too.

This solves this issue.

Please let me know what you think. There might be a better way of doing this. Thank you very much

bogdanRada commented 8 years ago

@marcj , can you please review also this pull request? It's been two months since was opened and i got no feedback. Thank you very much :)

bogdanRada commented 7 years ago

any chance this would get reviewed? It's been 4 months since i opened it. @marcj can You please take a look?

bogdanRada commented 7 years ago

any updates on this ?:D