search

marcjordant / NumericKeyboard

Numeric keyboard input view for iPad
MIT License
34 stars 19 forks source link

Add support for UITextView and upgrade to Swift 4 #5

Open ryanjm opened 6 years ago

ryanjm commented 6 years ago

@marcjordant not sure if you would want these changes, but thought I'd offer. I added support for UITextView and updated the project to Swift 4.

In the process of creating this PR I realized there was not .gitignore so I added one of those two and removed my files that weren't needed.

BertPorter commented 6 years ago

I am using the revised version by Ryan Mathews. I recommend you update your master. The issue of duplicate decimal points is a deal breaker for many apps. Thank you.

jungalwala commented 5 years ago

@ryanjm I am looking to use your changes, but not 100% fluent in git. How can I clone your changes?

ryanjm commented 5 years ago

@jungalwala you can go to my page on ryanjm/NumericKeyboard and click Clone (top right there is a green button). You can download a zip with all the files or you can use the url there to do a git clone on your machine.

jungalwala commented 5 years ago

@ryanjm Thanks for the information. I am upgrading to Swift 4.2 and see the following errors: /Pods/NumericKeyboard/NumericKeyboard/Classes/NKInputView.swift:254:99: 'UIControlEvents' has been renamed to 'UIControl.Event'

I am seeing 12 similar errors.

ryanjm commented 5 years ago

@jungalwala I'm not actively maintaining that project anymore so you'd need to go through those errors and update them yourself (it'd be great if you created a PR for them). That type of error will be really easy to update.

Good luck.